Repository navigation
Make the configurator language setting easier to find - #419
Merged
Merged
Conversation
Put the language picker first in General UI, with a globe and a title that includes every supported language. Derive its title and search terms from shared language metadata. Add regression coverage for the title, icon and row order, and format the additions with the pinned Rust toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choosing an unfamiliar interface language can make the setting hard to find again. Move the language picker to the first row of General UI, add a globe icon, and show
Language / 语言in English or语言 / Languagein Chinese.Build the title and cross-language search terms from shared language metadata, update the guide for adding languages, and add regression coverage for the title order, icon and row placement. The additions also pass the pinned formatter.
Validation:
RUSTUP_TOOLCHAIN=1.98.1 ./tools/lint-and-test.shgit diff --check