Repository navigation
Keep saved font and color values independent of the UI language - #416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the configurator uses Chinese, loading or selecting fonts and named colors can put translated labels into configuration values. Saving can then fail validation or store a color name the overlay does not recognize.
Keep the font and color conversion methods on canonical English values while leaving dropdown labels translated. Remove the unused lowercase catalog entries and document that configuration values must stay independent of the interface language.
Add regressions for a Chinese config draft round trip and for every font and named-color option in both languages. The language-changing tests run in isolated child processes.
Validation:
cargo test --locked -p wayscriber-configuratorcargo test --locked -p wayscriber --test repository_guards translations::cargo test --locked -p wayscriber --lib config:: -- --test-threads=1cargo fmt --all -- --checkgit diff --checkThe full local gate was not rerun for this review; hosted CI will validate the PR.