Repository navigation
chore: load @types/node explicitly in tsconfig - #16
Merged
Merged
Conversation
TypeScript 6 changes the `types` default to [], so @types/node is no longer picked up automatically and `pnpm build` fails with "Cannot find name 'process'" (and require, console, URL). That is what fails the TypeScript 6.0.3 bump in #15. Listing node in `types` works on 5.9 too, so this can land first and #15 rebases onto it. The build output is byte-identical to the committed dist/index.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 6 changes the
typesdefault to [], so @types/node is no longer picked up automatically andpnpm buildfails with "Cannot find name 'process'" (and require, console, URL). That is what fails the TypeScript 6.0.3 bump in #15. Listing node intypesworks on 5.9 too, so this can land first and #15 rebases onto it. The build output is byte-identical to the committed dist/index.js.