Skip to content

ci(claude-review): stop silent no-comment review runs - #213

Open
riglar wants to merge 1 commit into
devfrom
ci/claude-review-wait-for-subagents
Open

riglar wants to merge 1 commit into
devfrom
ci/claude-review-wait-for-subagents

Conversation

@riglar

@riglar riglar commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Problem

Claude Code Review sometimes finishes green without posting anything. dcd hit this often and fixed it in devicecloud-dev/dcd#1536. This repo uses the same workflow, so it has the same gap.

The /code-review plugin starts several reviewer subagents. The main agent sometimes starts them in the background and ends its turn to "wait" for them. In headless mode, ending the turn ends the session. So no comment is posted, and the action still exits success.

Changes

Same as dcd#1536:

  • Add --append-system-prompt to claude_args. It tells the agent it is running non-interactively and must not background subagents or schedule wakeups. It must wait for every reviewer and post the comment before stopping.
  • Add a step after the review that fails the job when claude[bot] posted no comment during the run. Both issue comments and inline review comments count. A skipped review now shows red instead of a silent green check.

Testing

  • YAML parses.
  • This PR runs the updated workflow on itself.

🤖 Generated with Claude Code

…ing is posted

Headless runs can background the bug-review subagents and end the turn
to 'wait' for them. In -p mode that ends the session, so no comment is
posted and the job still goes green. Port of devicecloud-dev/dcd#1536.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant