Fix missing required argument in ADUserCreds Report constructor - #132
Merged
fang0654 merged 1 commit intoSep 10, 2026
Merged
Conversation
The 'Report' class in ADUserCreds.py overrode 'ReportTemplate.__init__' in an incompatible manner. 'ReportTemplate' defined 'def __init__(self, db=None): pass', while 'ADUserCreds.Report' defined 'def __init__(self, db): pass', making 'db' a required argument by omitting the default None value. Removes the __init__ methods for both ReportTemplate and ADUserCreds.Report, since the 'db' argument was never used and no callers in the package supplied it.
Collaborator
|
Oh yeah, this is left over from armory v1. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_report_optionsinarmory_cmd.pyraisesTypeErrorfor theADUserCredsreport template due to a missing required argument:Root cause
The
Reportclass inADUserCreds.pyoverrodeReportTemplate.__init__in an incompatible manner.ReportTemplatedefineddef __init__(self, db=None): pass, whileADUserCreds.Reportdefineddef __init__(self, db): pass, makingdba required argument by omitting the defaultNonevalue.Fix
Remove the
__init__methods for bothReportTemplateandADUserCreds.Report, since thedbargument was never used and no callers in the package supplied it.