Repository navigation
deps: upgrade Rust, Python, CI and tool dependencies - #1866
Merged
Merged
Conversation
cargo update moves 67 packages within their semver ranges (actix-web 4.19.0, serde-saphyr 2.1.1, toml 1.2.1, cc 1.11.1, among others); no package is held back by the 1.94 MSRV. actix-web 4.19's default feature set is unchanged apart from http2, so the explicit list in big-code-analysis-web stands; only its comment's version moves.
Test-only dependency of the root and CLI crates, used by the SARIF validators. The draft7::new / iter_errors / instance_path surface the validators call is unchanged; a scratch probe against the vendored SARIF 2.1.0 schema confirmed 0.61.1 still rejects an invalid document and accepts a valid one.
Patch updates only (cc 1.11.1, itoa, syn, winnow, const-oid, ctutils, fixedbitset). None of these crates is built on the 1.94 MSRV toolchain in CI; make enums-check, make fuzz-check and each grammar crate's own cargo test pass.
uv lock --upgrade moves 25 packages within the existing bounds (maturin 1.16.0, mypy 2.4.1, pytest 9.2.0, pandas 3.1.1, among others), and the dev / examples exports are regenerated with the py-relock commands. Two transitive majors arrive through the examples extra: python-dateutil 4.0.0 and soupsieve 4.1. py-typecheck, py-test and py-stubtest pass on the dev extra; jupyter_quickstart.ipynb executes all six cells without error in a fresh venv built from requirements/examples.txt, as the CI notebook job does.
Raise the dev-extra bound to <0.18, upgrade ruff in uv.lock, regenerate the dev export, and move the ruff-pre-commit rev in lockstep. ruff 0.17.4 reports no lint findings and no formatting changes under the explicit select set; make check-ruff-lockstep passes. The Makefile comment that named the old ceiling now refers to it generically.
taiki-e/install-action 2.90.1 -> 2.90.3 (tool-manifest refreshes only) and mikepenz/action-junit-report 6.7.0 -> 6.7.1 (annotation fixes), each pinned to the release commit. dorny/paths-filter's SHA was already v4.0.3; only its trailing tag comment is made exact. Every other action is at its latest release.
rumdl 0.3.2 -> 0.3.3, shellcheck 0.10.0 -> 0.11.0, shfmt 3.12.0 -> 3.14.1 and checkmake 0.2.2 -> 0.3.2, with every SHA256 taken from the downloaded artifact and, where upstream publishes one, checked against its checksum file. The rumdl and checkmake lockstep baselines are refreshed with `check-rumdl-lockstep.py --update`. checkmake moved from mrtazz/checkmake to checkmake/checkmake, which now publishes amd64 and arm64 builds of the same release. CI and both Dockerfile arms therefore install one version from one repository, and the separate CHECKMAKE_FORK_VERSION for arm64 is gone; docker/README.md and the lockstep gate's docstring say so. `make lint` passes with all four new binaries on PATH, and each reports nothing the old version did not.
Release workflows: cargo-about 0.8.4 -> 0.9.3 (also ci.yml's license-audit job), cargo-deb 3.6.3 -> 3.8.0, cargo-generate-rpm 0.20.0 -> 0.21.1, cargo-cyclonedx 0.5.7 -> 0.5.10. ci.yml's coverage job moves cargo-nextest to 0.9.151. The Dockerfile follows with cargo-binstall 1.26.2 and uv 0.13.7 (both SHA256-verified against the downloaded artifact; uv's also against upstream's .sha256), and cargo-insta 1.49.0, cargo-nextest 0.9.151, cargo-llvm-cov 0.9.1 and cargo-about 0.9.3 in its binstall list. cross 0.2.5 is already the latest release. Checked locally against the old versions on this tree: - cargo-about: both THIRD-PARTY-LICENSES files generate under the same about.toml. 0.9 attributes crates 0.8 dropped (rustix, linux-raw-sys, zstd-sys, tracing-core, encoding_rs's BSD-3-Clause half) and now also lists the MPL-2.0 workspace crate itself. - cargo-deb: identical control fields and file lists for both .debs. - cargo-generate-rpm: identical file lists; the arch provide becomes RPM's standard ISA form, `name(aarch-64) = 2.5.2-1`, where 0.20 wrote `name(aarch64) = 2.5.2`. - cargo-cyclonedx: identical component sets and metadata for all three SBOMs at --spec-version 1.5. - cargo-binstall 1.26.2 resolves prebuilt binaries for every tool in the Dockerfile's list (dry run).
…probe @anthropic-ai/claude-code 2.1.322, @upstash/context7-mcp 4.6.0, pyright 1.1.414 and bash-language-server 5.8.1; @optave/codegraph 3.17.0 is already the latest. cargo-binstall 1.26 made `--version` an option that takes the version to install, so the post-install probe `cargo binstall --version` failed the build; it is now `cargo binstall -V`. The ubuntu:noble digest is already the current one. A local `docker build` (linux/arm64) succeeds, and every pinned tool in the image reports its pinned version.
What is left of this branch's Groovy 0.5.0 bump after rebasing onto 1653ac8, which landed the same bump on main with a fuller follow-through. Every conflict was resolved to main's side; only what main does not have remains: - `groovy_type_arguments_reach_kind_id_as_the_alias` reads the id of every `type_arguments` node in a field type, a cast, a `new` and an `implements` clause, a direct census beside the Halstead pair test the getter comment names. - Two comments still cited 0.3.0 ids: `QualifiedType2` is 230 and `BooleanLiteral` 272.
…hanges The cargo-about and cargo-generate-rpm bumps in c293471c change the shipped THIRD-PARTY-LICENSES files and the RPM's arch-qualified Provides string; both reach package consumers, so they go under Unreleased.
What remains of the argon-review and fable-review follow-ups after rebasing onto 1653ac8, which already un-ignored the nested and anonymous class tests, added the annotated enum constants and updated the 0.3.0 comments. Conflicts were resolved to main's side; these additions are not on main: - The three `groovy_nested_inner_classes` tests (npm, npa, wmc) also assert the per-space sums of `X`, `Y` and `Z`. The file-level sums they checked read the same when a nested class's members are charged to the wrong space. - The `Record` keyword gate has a reachable negative, which main's comment said it lacked. The scanner emits `record` before a name and `(` or `<`, so `record a<b` strands the leaf under an `ERROR`. `groovy_declaration_keywords_are_operators_1552` gains that row and probe; with the gate removed the row reads [2, 2] instead of [1, 1]. The gate's doc comment in roles/groovy.rs says the same. - Two comments in halstead.rs still cited `QualifiedType2` as 228; it is 230.
taiki-e/install-action v2.90.3's manifest stops at 0.5.9, so the release job takes its cargo-binstall fallback for 0.5.10, as it always has for cargo-generate-rpm. A local binstall dry run resolves the prebuilt x86_64-unknown-linux-gnu asset. Recorded beside the pin so the release-day warning is expected.
Fixes from a review of the pull request. - The changelog said the CycloneDX SBOM components were unchanged, but that comparison had used cargo-cyclonedx 0.5.9 and only component names and versions. Regenerated with the old pin, 0.5.7, and with 0.5.10 (`cargo cyclonedx --format json --all --describe crate --spec-version 1.5`) and diffed every JSON path of the three SBOMs: besides the timestamp, serial number and tool version, the one difference is that each crate's own build targets under `metadata.component.components` gain `licenses: MPL-2.0` (1, 2 and 2 entries). The 193 / 229 / 328 dependency components and the dependency graphs are identical. The entry now says so. - The RPM entry was incomplete: the plain `Provides` also gains the release, and the `rpmlib(...)` requirements move from `=` to `<=`. File lists and file flags are identical. - A new comment in wmc.rs said the total "still read 2" at grammar 0.3.0 while the test asserts 3. The per-space sums matter because the total reads 3 wherever the methods land; the comment says that. - Three comments had their raw kind ids updated (228 -> 230, 270 -> 272). 1653ac8 named variants instead of ids, so they now name `QualifiedType2` and `BooleanLiteral` without a number. make pre-commit passes (7224 tests).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 400 400
Lines 123822 123849 +27
Branches 123387 123414 +27
=======================================
+ Hits 121950 121977 +27
Misses 1144 1144
Partials 728 728
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the Rust, Python, CI and tool dependencies. The
tree-sitterruntime stays at=0.26.13, because it is blocked upstream (see "Not upgraded").The branch is rebased onto
90ea3ed7.maingained the Groovy 0.5.0 bump (1653ac8c) while this branch was open, so this PR no longer contains that bump. It keeps only two small Groovy test commits that add to it.What changes
Cargo.lockcargo update: 67 packages, including actix-web 4.19.0, serde-saphyr 2.1.1, toml 1.2.1 and cc 1.11.1. No package is held back by the 1.94 MSRV.jsonschema^0.59→^0.61(test-only, the SARIF validators)enums,fuzzand the fivetree-sitter-*cratesuv lock --upgrade(25 packages) and both hash-pinned exports; ruff 0.16.10 → 0.17.4 with the bound, the lock and the pre-commitrev:moved togethertaiki-e/install-actionv2.90.3 andmikepenz/action-junit-reportv6.7.1. Every other action and theubuntu:nobledigest were already current.Things a reviewer should know
checkmake changed repository.
mrtazz/checkmakemoved tocheckmake/checkmake, which publishes amd64 and arm64 builds of one release. CI and both Dockerfile arms now install the same version, andCHECKMAKE_FORK_VERSIONis removed.cargo-binstall 1.26 broke the image build.
--versionnow takes a value, so the probe iscargo binstall -V.The RPM metadata changes. cargo-generate-rpm 0.21 writes
big-code-analysis-cli = 2.5.2-1andbig-code-analysis-cli(aarch-64) = 2.5.2-1; 0.20 wrote= 2.5.2and(aarch64) = 2.5.2. Therpmlib(...)requirements use<=where they used=. Nothing in this repository reads either.The license files grow. cargo-about 0.9 lists crates that 0.8 missed (
rustix,linux-raw-sys,zstd-sys,tracing-core) and the workspace's own MPL-2.0 crates.cargo-cyclonedx 0.5.10 installs through the cargo-binstall fallback. The pinned install-action manifest stops at 0.5.9. A local binstall dry run resolves the prebuilt
x86_64-unknown-linux-gnuasset, and a comment beside the pin records it.actix-web feature list. 4.19.0's
defaultset equals our explicit list plushttp2, which stays off (h2 0.3 is banned indeny.toml).The SBOMs gain one field. With cargo-cyclonedx 0.5.10, each crate's own build targets under
metadata.component.componentscarrylicenses: MPL-2.0.The RPM, license and SBOM changes are recorded under
## [Unreleased].Groovy commits that remain
main's1653ac8cmade the same grammar bump with a fuller follow-through, so every rebase conflict was resolved tomain's side. Two commits remain:e14b4fac: a direct census of thetype_argumentsalias id, and two stale kind ids in comments (QualifiedType2is 230,BooleanLiteralis 272).fc36e660:groovy_nested_inner_classestests (npm, npa, wmc) also assert the per-space sums ofX,YandZ. Their file-level sums read the same when members are charged to the wrong space.Recordkeyword gate has a reachable negative.main's comment said it had none, but the scanner emitsrecordbefore a name and(or<, sorecord a<bleaves the keyword under anERRORnode.groovy_declaration_keywords_are_operators_1552gains that row; with the gate removed it reads[2, 2]instead of[1, 1].Not upgraded
tree-sitterruntime 0.27.2: blocked.tree-sitter-perl1.1.2, the latest release, has a normal dependency ontree-sitter ^0.26.3, andlinks = "tree-sitter"allows only one copy. With the pin at=0.27.2,cargo update -p tree-sitterfails withrequired by package tree-sitter-perl v1.1.2. Tracked in deps: bump tree-sitter runtime to 0.27 (blocked on tree-sitter-perl) #1652, which has a comment with this run's findings.tree-sitter-cli0.27.2: stays at 0.26.9, because it has to move with the runtime. Its npm prebuilt also needs glibc 2.39.Verification
make pre-commitwas re-run atd5a8b3a4, which changes only comments and the changelog. All other commands were run at77716f6bon aarch64 Linux with rustc 1.99.0, unless a row says otherwise.make pre-commitBCA_GATE: pass; 7224 tests passed, 6 skipped, no snapshot changescargo +1.94 build --all-features --workspace --lockedutils/check-deny-manifests.sh advisories bans licenses sourcesmake fuzz-checkmake check-test-lang-gates-compare COMPARE_REF=origin/mainmake lintwith the new lint binaries onPATHcargo about generate --lockedforbcaandbca-web, cargo-about 0.9.3docker buildof the dev image,linux/arm64make py-typecheck py-test py-stubtestrequirements/examples.txtin a fresh venvChecksums: every SHA256 in the Dockerfile and
ci.ymlwas computed from the downloaded artifact. rumdl, uv and checkmake were also checked against upstream's published checksum files.Old and new release tools were compared on this tree:
.deb: identical control fields and file lists..rpm: identical file lists and file flags; only the metadata above differs.--spec-version 1.5(run at77716f6b): besides the timestamp, serial number and tool version, the only difference is theMPL-2.0field above (1, 2 and 2 entries). The 193, 229 and 328 dependency components and the dependency graphs are identical.The rebase was checked by tree: every file that differs from the pre-rebase backup branch is a file
mainitself changed.Not verified: the GitHub Actions workflows (they run only after a push), the amd64 image build, and the release workflow, which runs only on a tag.
Reviews
Three independent reviewers read the branch before the rebase: astra-review, argon-review and fable-review. Their should-fix findings were addressed. After the rebase, most of the Groovy findings are covered by
main's1653ac8c, and the rest are infc36e660.Refs #1652