Repository navigation
fix(utils): validate trace ID slice bounds before addition - #11951
Open
embrace897 wants to merge 1 commit into
Open
embrace897 wants to merge 1 commit into
embrace897 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetTraceIdIndex accepts negative lengths and computes start+length before validating the slice bounds. Invalid lengths or overflowing offsets can therefore panic instead of returning an error. Reject nonpositive lengths and validate against the remaining string length before calculating the end offset.
Validation: an isolated Go harness uses the production function and hash implementation. The original code panics on a negative length; the patch passes four invalid-boundary cases and two valid cases. A package regression is included. Full utils package, server and eBPF validation were not run. Configuration-level reachability of invalid values was not established.
Prepared with AI assistance.