Repository navigation
fix(datatype): avoid overflow when merging maximum port ranges - #11949
Open
embrace897 wants to merge 1 commit into
Open
embrace897 wants to merge 1 commit into
embrace897 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SplitPort2Int adds one to a uint16 upper endpoint when checking whether ranges overlap or are adjacent. At 65535 this wraps to zero, leaving overlapping ranges such as 0-65535,80 unmerged. Widen endpoints to uint32 before the addition.
Validation: an isolated Go harness using the production parsing/merge functions reproduces the failure before the change and passes three boundary inputs afterward. A package regression test is included. Full datatype package testing could not complete because dependencies could not be downloaded; full server and eBPF validation were not run.
Prepared with AI assistance.