Repository navigation
Conversation
Signed-off-by: Ruslan Gorbunov <ruslan.gorbunov@flant.com>
fuldaxxx
marked this pull request as ready for review
October 9, 2026 07:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
github.com/werf/nelmv1 togithub.com/werf/nelm/v2(v2.0.0-alpha.2, the same version Deckhouse'sfeat/nelm-v2-migratebranch uses) and drop thereplace github.com/docker/cli => v27.1.1directive fromgo.mod.dmtcan be installed withgo installagain.prometheus/prometheusto v0.312.0 so it matches theprometheus/commonv0.67.5 that nelm v2 pulls in. Adapt rule validation to the new API:parser.NewParser(...).ParseExpr, plus explicitmodel.UTF8Validationfor label and metric names, which is the same scheme that was the default before./or.as a remote chart reference, so a relative path likemodules/foowas being sent to the chart downloader.templates-testssnapshots taken under nelm v1 valid. nelm v1 always emitted top-levelmetadata.labels/metadata.annotations({}when unset) and v2 omits them, so the tester fills them in before comparing. Existing snapshots don't need to be regenerated.Why do we need it, and what problem does it solve?
go install github.com/deckhouse/dmt/cmd/dmt@latesthas been broken since v0.2.4:➜ ~ go install github.com/deckhouse/dmt/cmd/dmt@latest
go: downloading github.com/deckhouse/dmt v0.2.5
go: github.com/deckhouse/dmt/cmd/dmt@latest (in github.com/deckhouse/dmt@v0.2.5):
The go.mod file for the module providing named packages contains one or
more replace directives. It must not contain directives that would cause
it to be interpreted differently than if it were the main module.
The cause is the
docker/clireplace added in #470.deckhouse/pkg/registrypinsdocker/cliv29 for a CVE fix. nelm v1 depends onoras.land/oras-gov1.2.x, which doesn't compile againstdocker/cliv29 (itsAuthConfigconversion breaks). No v1.2.x release of oras-go has a fix, and every nelm v1.x release depends on oras-go v1.2.x, so the replace couldn't be removed while dmt stayed on nelm v1.nelm v2 uses
oras-go/v2and no longer depends ondocker/clithrough oras, so the replace is no longer needed:➜ ~ go install github.com/deckhouse/dmt/cmd/dmt@e29a900bb7057eee4f2808aef1c0563680f9c635
go: downloading github.com/deckhouse/dmt v0.2.6-0.20261009070237-e29a900bb705
➜ ~
The other changes are what the nelm v2 bump requires: a matching prometheus version, absolute chart paths (v2 removed the remote-charts feature gate, so relative paths get treated as remote charts), and keeping existing snapshots compatible.