Repository navigation
[deckhouse-cli] Backport kubectl plugin fix to release-0.32 - #506
Merged
Merged
Conversation
d8 k passed the whole d8 argv to kubectl's plugin lookup, so the "k" word became part of the plugin name: `d8 k argo rollouts get` searched PATH for kubectl-k-argo-rollouts and never found kubectl-argo-rollouts. Since Deckhouse 1.76 nodes alias kubectl to `d8 k`, so every kubectl plugin stopped working there. Drop the "k"/"kubectl" word before the lookup. Every other d8 command now passes no arguments to this lookup, so the d8 k command tree no longer runs kubectl-<name> for `d8 <name>`. (cherry picked from commit b3f6fe3) Signed-off-by: Yuriy Losev <yuriy.losev@flant.com> Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #505 to
release-0.32for DKP 1.76.d8 k argo rollouts getsearched forkubectl-k-argo-rolloutsinstead of the installedkubectl-argo-rollouts. The fix removes thekorkubectlcommand word before plugin lookup and passes the remaining arguments to the plugin.The conflict around
ConfigFlagskeeps the release branch's existing configuration. The helper and tests match the original fix.Tests
Both commands passed on this branch:
Notes
The separate plugin lookup in embedded delivery-kit remains unchanged. Updating that dependency is a separate task.