Repository navigation
fix(evals): distinguish permission status from credential disclosures - #188
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5eaae8801c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspection document capture rejected ordinary permission statements such as “Separate authorization is required before product repairs.” The global copular scanner treated the permission noun as a credential field before it reached the existing colon-permission policy.
This change examines each copular occurrence independently. Bare authorization can describe permission only in plain prose with a complete, bounded relation to task work. Credential values, aliases, ambiguous status words, quoted or coded contexts, and later disclosures remain unavailable. Mixed spaces and tabs are checked at both the field and predicate positions; ordinary unindented wrapping remains observable. LF, CRLF and CR share the same context rules. Blockquotes and their continuation lines remain private; quote-like output inside a closed code fence does not affect following plain prose.
The colon-assignment policy and public file, byte, hash and retention checks remain unchanged. Captured documents are preserved byte-for-byte. RED commits precede the fixes, and public file/snapshot regressions cover permission lifecycle statements, opaque values, independent later disclosures and the indentation family.
Validation passes on clean head
fd174917. Full preflight passes 3,342 tests with 20 existing skips and zero failures. Independent review passes 240 public capture controls and 393 focused tests. Owner focused checks pass 345 tests. Exact-head comment audit passes. Fresh canonical packing reproduces the approved 9.6.0 tarball and full unpacked manifest; product bytes, release policy, case catalog and canonical plan are unchanged.Original failed and operator-stopped campaigns remain immutable and receive no qualification credit. A fresh complete live qualification and genuine conditional canary remain required before release.