Repository navigation
fix(evals): retain permission prose and grade inspection evidence - #187
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dce86b8e54
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspection qualification rejected a legitimate permission statement as a credential, missed “audit failure” wording, and failed to recognize an actionable “Resolve” phase. This change accepts those forms through the actual document capture and scenario grader.
The permission exception requires ordinary task prose outside code and applies only to its paragraph. Actual credential assignments and disclosures remain blocked throughout the document. Audit grading accepts truthful failure statements and rejects contradictory success claims, including “completed successfully”. Phase grading recognizes imperative Resolve actions while rejecting passive or incomplete plans.
Regression tests cover retained native document bytes, credential leaks, benign later headings, failure/success contradictions, and actionable phase boundaries. Original failed campaign outcomes remain unchanged; diagnostic replay supplies no qualification credit.
Validation passes on clean head9da1b80a. Focused tests144 pass; full preflight3132 pass,20 existing skips,0 failures. Independent review passes80 behavior probes, two retained-document title substitutions and two native document capture checks. Exact-head comment audit passes. Fresh canonical packing reproduces the approved 9.6.0 tarball and full unpacked manifest without restoration. Product bytes, release policy, case catalog and canonical plan remain unchanged.
A fresh complete live qualification and genuine conditional canary remain required before release.