[davesnx]

make format and make format-check now pass --root . to dune. In a worktree inside the checkout (for example .workplace/worktrees/<task>), dune took the outer checkout as its root and failed with "Don't know about directory ... specified on the command line!". The pre-push hook runs make format-check, so pushes from such a worktree failed.

Checked: the hook failed from a nested worktree without this change and passed with it; this branch was pushed with the hook running.

Risk: two-way door; a revert restores the old dune calls.

Summary by CodeRabbit

• Chores
  • Updated formatting commands to run consistently from the project root.
  • Preserved automatic formatting updates for the formatting command and validation-only behavior for format checks.
  • Continued to run both commands without the global Dune lock.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1adb35fe-3ffb-41b5-ad03-bde58a2565ee

📥 Commits

Reviewing files that changed from the base of the PR and between 5c0318b and 96c9b2e.

📒 Files selected for processing: 1

• Makefile

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The format and format-check Makefile targets now pass --root . to Dune. The targets retain their existing auto-promotion and global lock settings.

Changes: Dune formatting targets

Layer / File(s)	Summary
Set Dune root for formatting Makefile	The format and format-check targets pass --root .. Auto-promotion remains enabled only for format, and the global Dune lock remains disabled for both targets.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 96c9b

No actionable merge-blocking risk was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: running the format check from the worktree root.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}