fix: Remove roles field from BGPRouter - #20
Merged
Conversation
BGPRouter carried a roles field for tagging routers as fabric, tenant, or transit, but nothing in the ownership model uses it — BGPRouter is already the binding target for BGPPeer, BGPAdvertisement, and BGPPolicy regardless of role. Dropped the field from spec and status, the RouterRole type, and its generated CRD schema, docs, and sample manifests. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
scotwells
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BGPRouter carried a
rolesfield for tagging routers as fabric, tenant, or transit, but nothing in the ownership model uses it — BGPRouter is already the binding target for BGPPeer, BGPAdvertisement, and BGPPolicy regardless of role. Removed the field from spec and status, along with theRouterRoletype and its generated CRD schema, docs, and sample manifests.Test plan
BGPRouterresources apply and reconcile without arolesfieldrolesset are accepted (field is silently dropped, not rejected)