Skip to content

fix: bump electron-builder to 26.18.1 and re-enable DMG release - #660

Merged
hanneshapke merged 2 commits into
mainfrom
fix/update-electron-builder
Oct 27, 2026
Merged

hanneshapke merged 2 commits into
mainfrom
fix/update-electron-builder

Conversation

@hanneshapke

@hanneshapke hanneshapke commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The lockfile diff is mostly electron-builder's own dependencies being reshuffled (fs-extra/jsonfile/universalify dedupe). There is still a single react@19.

Test plan

  • npx electron-builder --version reports 26.18.1
  • release.yml parses; jobs and create-release.needs include build-dmg
  • Signed DMG build succeeds on the next release run (_build-dmg.yml)
  • Homebrew cask publishes for the next stable release

🤖 Generated with Claude Code

hanneshapke and others added 2 commits October 27, 2026 09:01
Picks up the macOS code-signing fix missing from 26.16.0
(electron-userland/electron-builder#10167): set-key-partition-list was
called with the .p12 import password instead of the temporary keychain
password, so CSC_LINK signing failed with SecKeychainUnlock errors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts b327149 (#657). With electron-builder 26.18.1 the CSC_LINK
keychain signing failure is fixed, so restore the build-dmg and
publish-homebrew-tap jobs, build-dmg in create-release's needs, and the
macOS release notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hanneshapke hanneshapke changed the title deps: bump electron-builder to 26.18.1 fix: bump electron-builder to 26.18.1 and re-enable DMG release Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Warning

This PR touches 3+ distinct areas of the codebase.

Consider splitting into smaller, focused PRs — each covering a single semantic type.
This makes reviews easier and keeps the git history clean.

Categories found:

docs:

  • .changeset/bump-electron-builder.md
  • .changeset/reenable-dmg-release.md

chore:

  • package-lock.json
  • src/frontend/package.json

ci:

  • .github/workflows/release.yml

@hanneshapke
hanneshapke merged commit d6f516e into main Oct 27, 2026
8 of 10 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant