Repository navigation
fix: bump electron-builder to 26.18.1 and re-enable DMG release - #660
Merged
Merged
Conversation
Picks up the macOS code-signing fix missing from 26.16.0 (electron-userland/electron-builder#10167): set-key-partition-list was called with the .p12 import password instead of the temporary keychain password, so CSC_LINK signing failed with SecKeychainUnlock errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning This PR touches 3+ distinct areas of the codebase. Consider splitting into smaller, focused PRs — each covering a single semantic type. Categories found: docs:
chore:
ci:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electron-builderfrom^26.15.3to^26.18.1insrc/frontend(lockfile updated).security set-key-partition-listwas called with the.p12import password instead of the temporary keychain password, soCSC_LINKsigning in CI failed withSecKeychainUnlock: The user name or passphrase you entered is not correct.release.ymlby reverting ci: temporarily disable DMG build and Homebrew tap in release #657: restores thebuild-dmgandpublish-homebrew-tapjobs, putsbuild-dmgback increate-release'sneeds, and restores the macOS release notes.The lockfile diff is mostly electron-builder's own dependencies being reshuffled (
fs-extra/jsonfile/universalifydedupe). There is still a single react@19.Test plan
npx electron-builder --versionreports 26.18.1release.ymlparses; jobs andcreate-release.needsincludebuild-dmg_build-dmg.yml)🤖 Generated with Claude Code