Skip to content

Add ESG Service EPG selector consistency check (CSCwv51642) - #506

Open
gautvenk wants to merge 1 commit into
datacenter:v4.3.1-devfrom
gautvenk:CSCww77700-esg-lifctx-consistency
Open

gautvenk wants to merge 1 commit into
datacenter:v4.3.1-devfrom
gautvenk:CSCww77700-esg-lifctx-consistency

Conversation

@gautvenk

Copy link
Copy Markdown

Adds esg_lifctx_selector_consistency_check for CSCwv51642.

Service EPGs (vnsLIfCtx) that use the same L4-L7 device and BD share one pcTag, so they must be selected by the same ESG (or none). Before 6.3(1), APIC validated only the provider-side Service EPG of a device selection policy, so a consumer-side Service EPG with a different ESG was accepted. Starting with 6.3(1), the consumer side is validated too, and changing an ESG selector re-renders every graph sharing the device and BD. After the upgrade, the next re-render of such a graph (post-upgrade processing or a configuration change) raises F1690 (lifctx-should-have-same-esg) / F0758, and the graph goes to failed-to-apply.

  • Runs when the target is 6.3(1) or later and the current release is 5.2(4) (Service EPG selector introduced) or later. Current releases already on 6.3(1)+ are checked too, because an affected graph stays applied until a re-render, which the upgrade can trigger. MANUAL without a target version.
  • Mirrors APIC: only device selection policies whose two Service EPGs are both on a BD, only the consumer-side Service EPG, compared against every Service EPG (consumer or provider, any graph) on the same vnsLDevVip + BD, including devices and BDs shared from tenant common.
  • Not reported (no new fault after the upgrade): provider-side-only mismatches, device selection policies with a Service EPG without a BD (L3Out), imported devices (vnsLDevIf).
  • Returns FAIL - OUTAGE WARNING!! with one row per affected graph: consumer-side Service EPG, its ESG, and the other ESGs on the device/BD.
  • 3 flat class queries: fvLIfCtxSelector, vnsRsLIfCtxToBD, vnsRsLIfCtxToLIf.
  • Docs: summary row d47 and a details section referencing the ACI PBR Service Graph Whitepaper. The check is ordered before the App Center check.

Verification:

  • 14 focused tests pass on Python 2.7 and 3.8; 1,473 tests pass on Python 3.8 after rebasing on v4.3.1-dev.
  • Live run on an APIC simulator (build with the fix; check run as 6.1(2f) → 6.3(1a) against live data):
    • 3 contracts sharing one device and BD, ESG on one consumer-side Service EPG: APIC failed-to-apply ×3 (F1690/F0758); check FAIL, 3 rows.
    • Same, ESG on one provider-side Service EPG only: APIC failed-to-apply ×3 (pre-existing behavior); check PASS.
    • 2 contracts in one tenant sharing a tenant-common device and BD, ESG on one consumer-side Service EPG: APIC failed-to-apply ×2; check FAIL, 2 rows.
    • No selectors: APIC applied; check PASS.
  • GitLab integration has not run.

Starting with 6.3(1), APIC also validates the consumer-side Service EPG
(vnsLIfCtx) of a device selection policy whose two Service EPGs are on a
BD, and re-renders every graph sharing the device and BD when an ESG
selector changes (CSCwv51642). A consumer-side Service EPG whose ESG
selection differs from another Service EPG on the same device and BD was
accepted before and fails to apply (F1690/F0758) on the next re-render
after the upgrade.

Tracked by CSCww77700.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant