Skip to content

docs: correct titlebar drag comment now that the main window is movable #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arzafran merged 1 commit into from
Oct 12, 2026
Merged

docs: correct titlebar drag comment now that the main window is movable #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/WindowSwizzles.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ extension NSWindow {
// The card's dead top-edge sliver (the padding-ring WindowDragHandleView
// mount in ContentView.swift doesn't fully cover it -- AppKit's hit-test
// bottoms out at the bare content host there) has no native drag:
// isMovable=false and isMovableByWindowBackground=false disable AppKit's
// own titlebar drag globally. Handle it here for genuine unclaimed
// MainWindowHostingView returns false from mouseDownCanMoveWindow and
// isMovableByWindowBackground is false, so AppKit never starts its own
// titlebar drag there. Handle it here for genuine unclaimed
// background only -- real controls (traffic lights, titlebar accessory
// buttons) and real content (terminal surfaces, bonsplit's tab bar, which
// are portal-hosted outside contentView's subtree by design) keep their
Expand Down
Loading