Repository navigation
refactor: remove unused imports, stale comments and stray prints - #422
Merged
Merged
Conversation
Drop unused import lines across Sources, CLI, tests and vendored bonsplit. Reword comments that narrate old behaviour into present tense, keeping the mechanism where it guards a future edit. Error-path print calls in ghostty init and the socket listener become NSLog so they still reach the system log in Release builds. Regenerate V2CommandCatalog.swift for the generator comment change and delete one dead local in TabBarView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Cleans up leftovers that make the code harder to read without changing what the app does. Unused imports go away, comments that narrate old behaviour ("used to", "previously", "ported from cmux") now describe the current code in present tense, and stray
printcalls on error paths becomeNSLogso they still land in the system log in Release builds.Summary
importlines across 74 files (Sources, CLI, tests, vendored bonsplit).print(...)calls in ghostty init and the socket listener toNSLog. Nodilogdiagnostics were touched.scripts/gen-v2-contract.pycomment wording changed andSources/V2CommandCatalog.swiftregenerated to match.Review order: nothing here is load-bearing. Skim
Sources/TerminalController.swiftandSources/GhosttyApp.swiftfor the print to NSLog swaps; the rest is import and comment fallout.Test plan
CIworkflow green (build, unit, socket, UI jobs).python3 scripts/check-structural-budgets.pyprintsstructural budgets: PASS.scripts/check-v2-contract.shprintsv2 contract check: OK.python3 scripts/check-settings-docs.pyprintsok:.