Repository navigation
Restrict web3signer host allowlist (bring #71 into main) - #75
Merged
Merged
Conversation
Replace --http-host-allowlist=* with the hostnames DAppNode packages and the DAppManager actually use to reach web3signer, so the unauthenticated keymanager API stays protected against DNS rebinding from browsers on the DAppNode VPN/Wi-Fi. Users can append hosts (or "*") through the new EXTRA_HOST_ALLOWLIST env var. The list is a superset of the one gnosis/lukso/hoodi already run with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checked against a live DAppNode (DAppManager 0.2.129): besides the stakers-module aliases the container also gets the bare service name, <domain>.private, web3signer.<domain>.private and its container name. No known caller uses them, but they are internal names, so allowing them costs nothing and avoids 403s for tooling that does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The web3signer flags are passed word-split, so "a.example, b.example"
made web3signer fail to start ("Unmatched argument at index 4:
'b.example'"). A typo in the package config must not stop the signer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restrict web3signer host allowlist to known DAppNode callers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#71 was stacked on #70's branch and merged into
marc/fix-mainnet-migrationafter #70 had already merged intomain, so its changes never reachedmain. This PR brings them over. The diff is exactly #71:services/web3signer/entrypoint.sh:--http-host-allowlistlists every hostname Docker and the DAppManager assign to the web3signer container, instead of*;EXTRA_HOST_ALLOWLIST.docker-compose.yml: addsEXTRA_HOST_ALLOWLIST: ""to the web3signer service.See #71 for the full allowlist, its callers and the validation. Merges cleanly with
main, and with #74 (web3signer 26.10.2) in a dry run.Release note to include: if something reaches web3signer by IP address or a custom hostname (for example a remote validator client), add it to
EXTRA_HOST_ALLOWLISTin the package config. Otherwise web3signer answers403 Host not authorized.🤖 Generated with Claude Code