Skip to content

DAOS-17995 dlck: check container's metadata + small fixes: - #18916

Open
janekmi wants to merge 5 commits into
masterfrom
janekmi/DAOS-17995-dlck-check-container-metadata
Open

DAOS-17995 dlck: check container's metadata + small fixes:#18916
janekmi wants to merge 5 commits into
masterfrom
janekmi/DAOS-17995-dlck-check-container-metadata

Conversation

@janekmi

@janekmi janekmi commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • fix memory leak in btr_nodes_check()
  • fix wrong argument processing in ck_report()
  • decrement indentation in case of an error in vos_pool_open_metrics()

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/1/execution/node/533/log

@janekmi
janekmi force-pushed the janekmi/DAOS-17995-dlck-check-container-metadata branch 2 times, most recently from 72d0f24 to 63eace9 Compare August 24, 2026 16:00
@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/2/execution/node/533/log

@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/3/execution/node/535/log

@janekmi
janekmi force-pushed the janekmi/DAOS-17995-dlck-check-container-metadata branch from 63eace9 to 2db0a3d Compare August 24, 2026 16:11
@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/4/execution/node/533/log

@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/5/execution/node/538/log

@janekmi
DAOS-17995 dlck: check container's metadata + ...
dcf8502 
... small fixes:

- fix memory leak in btr_nodes_check()
- fix wrong argument processing in ck_report()
- decrement indentation in case of an error in vos_pool_open_metrics()

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi
janekmi force-pushed the janekmi/DAOS-17995-dlck-check-container-metadata branch from 2db0a3d to dcf8502 Compare August 24, 2026 16:38
@janekmi
janekmi marked this pull request as ready for review August 24, 2026 16:40
@janekmi
janekmi requested review from a team as code owners August 24, 2026 16:40
@github-actions

github-actions Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Ticket title is 'dlck: check container's metadata'
Status is 'In Review'
Labels: '2.8pp'
https://daosio.atlassian.net/browse/DAOS-17995

@janekmi
janekmi requested review from Nasf-Fan and NiuYawei August 24, 2026 16:40
@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/6/execution/node/533/log

@janekmi
janekmi removed the request for review from NiuYawei August 24, 2026 16:46
@janekmi
DAOS-17995 dlck: initialize the dae pointer
1cfe207 
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Test RPMs on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/7/execution/node/1197/log

@janekmi
DAOS-17995 dlck: clang-format fix
75dd1aa 
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi janekmi changed the title DAOS-17995 dlck: check container's metadata + two small fixes: DAOS-17995 dlck: check container's metadata + small fixes: Aug 24, 2026
@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/7/execution/node/1309/log

@daosbuild3

daosbuild3 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Test stage Test RPMs on Leap 15 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18916/8/execution/node/1203/log

@janekmi
janekmi requested a review from grom72 August 25, 2026 07:52
Nasf-Fan
Nasf-Fan reviewed Aug 26, 2026
View reviewed changes
Comment thread src/common/btree.c
Comment thread src/utils/dlck/cmds/dlck_cmd_check.c
param.ip_flags = VOS_IT_FOR_CHECK;

return vos_iterate(&param, VOS_ITER_COUUID, false, &anchors, cont_process, NULL, &cb_arg,
NULL);

@Nasf-Fan Nasf-Fan Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be as backend consistency verification utils, it is expected that one container corruption should not affect the checking of other containers in the same pool, or we can allow the user to specify fallout or fail-continue.

@janekmi janekmi Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. For now I adopted the minimal solution: check all containers unconditionally. If having an option to would be desirable we can always introduce it in the future.

Comment thread src/vos/vos_container.c Outdated
cont->vc_mod_epoch_bound = d_hlc_get();

rc = vos_dtx_act_reindex(cont);
CK_PRINT(ck, CK_DBD_LIST_STR "...\n");

@Nasf-Fan Nasf-Fan Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to rename CK_DBD_LIST_STR as CK_ACT_DBD_LIST_STR. Because we maintain both active DXT table and committed DTX table in VOS. Here, we only reindex the active DTX table, then your logic only verifies the active DTX table blob.

@janekmi janekmi Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread src/vos/vos_dtx.c
while (!UMOFF_IS_NULL(dbd_off)) {
int dbd_count = 0;

CK_PRINTF(ck, CK_DBD_FMT "\n", dbd_off);

@Nasf-Fan Nasf-Fan Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CK_DBD_FMT => CK_ACT_DBD_FMT

@janekmi janekmi Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this "DTX blob (off=%#lx)... " format can be used in the future for both blobs on the active and committed lists. There is nothing specific to active DTX blobs about it. What do you think? 🤔

janekmi added 2 commits August 26, 2026 09:19
@janekmi
DAOS-17995 dlck: rename CK_DBD_LIST_STR -> CK_ACT_DBD_LIST_STR and...
4e984cb 
... call this list active explicitly.

Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi
DAOS-17995 dlck: continue checking other containers even if one failed
d48a1dd 
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
@janekmi
janekmi requested a review from Nasf-Fan August 26, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grom72 grom72 Awaiting requested review from grom72
@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janekmi @daosbuild3 @Nasf-Fan