Repository navigation
Fix IppResponseException generated when responding to a request with bad request-id value - #44
Merged
Conversation
…bad request-id value
…uests and responses
Owner
|
@61131 thank! I agree. I made small changes. I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unhandled IppResponseException was raised when executing the ipp-1.1.test against IppPrinter. This exception was caused by IppResponseMessageValidator.ValidateCore when validating the request-id value copied into the response message. However, this field should not be validated when generating a response.
From RFC 8011 4.1.2:
As such, where a request is submitted with an invalid request-id, SharpIppNext must be able to create a response message with an invalid request-id in order to provide a meaningful response. This PR removes the request-id validation from the IppResponseMessageValidator and the corresponding test.