Repository navigation
Fix predefined macro checks in elsif branches - #132
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The predefined-macro check in each
elsifloop uses the identifier from the openingifdef/ifndef, rather than the identifier on the currentelsif. This changes which valid source reaches the parser:parse_sv_strcurrently returns a syntax tree containingfallback, although__FILE__is predefined andselectedshould be chosen. Conversely, afterifndef __FILE__, anelsif UNDEFINEDis incorrectly treated as true. Both__FILE__and__LINE__are affected.Change
elsifidfor predefined status in both conditional-directive paths.parse_sv_strregression tests asserting the resulting module identifiers across both builtins and both opening directives.elsif UNDEFINEDbranch must not be emitted. Source line counts are unchanged.Validation
cargo testpasses on Ubuntu 24.04 / stable Rust 1.98.1: 127 passed, 1 pre-existing ignored.