Repository navigation
Fix sorted metadata for unsorted tags - #355
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ptags --unsortedpasses--sort=noto the workers, but not to the separate ctags invocation that creates the tag-file header. A source file definingzetabeforealphatherefore produces those tags in that order while advertising!_TAG_FILE_SORTED\t1. Consumers use this field to choose sorted-file lookup, so the header must describe the actual output.Change
Pass the same unsorted setting when generating the header. Keep the default sorted behavior unchanged. Add public
run_optintegration coverage using a temporary C source and explicit input list/output/directory, checking both the metadata and tag order.Validation
cargo test --locked --test tag_sort -- --test-threads=1.cargo test --locked --no-run, changed-file rustfmt check andgit diff --checkpass.