Skip to content

Publish share configuration and directory search - #377

Closed
ShayHanan wants to merge 1 commit into
ctera:masterfrom
ShayHanan:CIS-1799-publish-share-and-directory-search
Closed

ShayHanan wants to merge 1 commit into
ctera:masterfrom
ShayHanan:CIS-1799-publish-share-and-directory-search

Conversation

@ShayHanan

@ShayHanan ShayHanan commented Nov 3, 2026 •

Copy link
Copy Markdown

Summary

  • Publish Shares.get_configuration so a crawl can read the raw share configuration, including directory, access type, devices, and ACL rules.
  • Publish DirectoryService.search_directory_services, a read-only searchAD lookup that returns rid and does not import accounts. fetch still calls syncAD.
  • CIS-1799. The access-map crawl (CIS-1800) depends on these calls.

Test plan

  • python -m unittest tests.ut.core.admin.test_shares tests.ut.core.admin.test_directory_services
  • Confirm search_directory_services calls searchAD and never syncAD
  • Confirm get_configuration returns the raw configuration, while get still returns ShareInfo

Made with Cursor


Note

Low Risk
Additive public API with refactored call sites; same Portal endpoints and semantics as before, with clearer separation between read-only search and account import.

Reviewed by Cursor Bugbot for commit caa0f42. Bugbot is set up for automated code reviews on this repo. Configure here.

…rawl.

The crawl needs a read-only share configuration and a searchAD lookup that does not import accounts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ShayHanan

Copy link
Copy Markdown
Author

Closing. The access-map spec (8d8dbde, CIS-1797) now says the crawl calls the pinned SDK's existing private methods, with no change to ctera-python-sdk. CIS-1799 is no longer needed.

@ShayHanan ShayHanan closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant