Repository navigation
Conversation
…rawl. The crawl needs a read-only share configuration and a searchAD lookup that does not import accounts. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Closing. The access-map spec (8d8dbde, CIS-1797) now says the crawl calls the pinned SDK's existing private methods, with no change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shares.get_configurationso a crawl can read the raw share configuration, including directory, access type, devices, and ACL rules.DirectoryService.search_directory_services, a read-onlysearchADlookup that returnsridand does not import accounts.fetchstill callssyncAD.Test plan
python -m unittest tests.ut.core.admin.test_shares tests.ut.core.admin.test_directory_servicessearch_directory_servicescallssearchADand neversyncADget_configurationreturns the raw configuration, whilegetstill returnsShareInfoMade with Cursor
Note
Low Risk
Additive public API with refactored call sites; same Portal endpoints and semantics as before, with clearer separation between read-only search and account import.
Reviewed by Cursor Bugbot for commit caa0f42. Bugbot is set up for automated code reviews on this repo. Configure here.