Repository navigation
Batch: 2 changes, one commit each - #54
Merged
Merged
Conversation
…f the removed clone (#7) Refs #7 Remaining, as each changes detection, an exit code or the README capture: hybrid classification of mlkem768x25519-sha256; a distinct exit code for tool errors; the score box border; repo-relative paths, and long paths cut from the left, for local scans; the migration score framed as a path forward; the recommendation line; RC2 named by algorithm; assert messages and comments counted as withheld narrative; jsonwebtoken npm dependency inventory.
… them with --include-skipped (#10) Refs #10 Remaining, since each changes what is reported or the exit code: default scanning of example, sample, demo, mock, fixture, testdata and documentation directories at lowered severity with Secret Detection excepted; removal of the -docs and _docs file-name rule; nonzero --fail-on exit when zero files were scanned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 2 commits in
internal/cli,pkg/scanner,pkg/reporter,docs, the README and the changelog.Included
examples,fixtures,testdata,docsand similar directories is never reported, with no notice and no flag #10)Verified on this exact tree
go build ./...: exit 0go vet ./...: exit 0gofmt -l .: no files listedgolangci-lint run ./...: exit 1, 89 issues (errcheck 49, staticcheck 40); the same command on origin/main f680a89: exit 1, 88 issues (errcheck 48, staticcheck 40); the one issue only on this tree: internal/cli/scan.go:652 errcheck,fmt.Fprintfgh run view 39623605194 --repo csnp/cryptoscan --json jobs(CI on origin/main f680a89): lint success, test success, build success, release skippedgo test -race -p 4 -v ./...: exit 0; 8 packages ok, 1 package with no test files;--- PASSlines: 364 top-level, 1154 including subtests;--- FAILlines: 0;--- SKIPlines: 0git ls-files | grep -i changelog: CHANGELOG.md, pkg/reporter/changelog_test.go (no changelog check script; the test file ran in the suite above)Not included
None.
Closes
Refs #7
Refs #10
How to merge
Rebase and merge, so that each change stays its own commit on
main.