Skip to content

Batch: 3 fixes, one commit each - #49

Merged
thebenignhacker merged 3 commits into
mainfrom
integrate/2026-10-21-r4
Oct 21, 2026
Merged

thebenignhacker merged 3 commits into
mainfrom
integrate/2026-10-21-r4

Conversation

@thebenignhacker

Copy link
Copy Markdown
Member

This pull request lands 3 commits in CHANGELOG.md, internal/cli, pkg/analyzer, pkg/reporter and pkg/scanner.

Included

Verified on this exact tree

  • go build ./...: exit 0
  • go vet ./...: exit 0
  • golangci-lint run ./... (golangci-lint 2.12.2): exit 1, 21 issues (errcheck: 15, staticcheck: 6)
  • golangci-lint run ./... on origin/main 247a2e3 in a separate worktree: exit 1, 21 issues (errcheck: 15, staticcheck: 6); pre-existing
  • golangci-lint run --max-same-issues=0 --max-issues-per-linter=0 ./...: 88 issues (errcheck: 48, staticcheck: 40) on this tree and 88 issues (errcheck: 48, staticcheck: 40) on origin/main 247a2e3; diff of the two issue lists with line numbers removed: no output
  • golangci-lint run --new-from-rev=origin/main ./...: 0 issues
  • go test -race -p 4 -count=1 -json ./...: exit 0; packages: 8 passed, 0 failed, 1 with no test files (pkg/version); tests: 1128 passed (346 top-level, 782 subtests), 0 failed, 0 skipped
  • changelog tests in pkg/reporter/changelog_test.go (TestChangelogEntries, TestRepeatedChangelogHeadings, TestChangelogReleasesHaveOneHeadingPerKind, TestChangelogSaysWhereSARIFAndCSVCarryTheCryptoJSText): 4 passed in the run above

Not included

None

Closes

Fixes #46
Fixes #47
Fixes #48

How to merge

Rebase and merge, so that each change stays its own commit on main.

@thebenignhacker
thebenignhacker merged commit ed98c62 into main Oct 21, 2026
4 checks passed
@thebenignhacker
thebenignhacker deleted the integrate/2026-10-21-r4 branch October 21, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant