Repository navigation
Batch: 3 fixes, one commit each - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 3 commits in
CHANGELOG.md,internal/cli,pkg/analyzer,pkg/reporterandpkg/scanner.Included
Verified on this exact tree
go build ./...: exit 0go vet ./...: exit 0golangci-lint run ./...(golangci-lint 2.12.2): exit 1, 21 issues (errcheck: 15, staticcheck: 6)golangci-lint run ./...onorigin/main247a2e3 in a separate worktree: exit 1, 21 issues (errcheck: 15, staticcheck: 6); pre-existinggolangci-lint run --max-same-issues=0 --max-issues-per-linter=0 ./...: 88 issues (errcheck: 48, staticcheck: 40) on this tree and 88 issues (errcheck: 48, staticcheck: 40) onorigin/main247a2e3;diffof the two issue lists with line numbers removed: no outputgolangci-lint run --new-from-rev=origin/main ./...: 0 issuesgo test -race -p 4 -count=1 -json ./...: exit 0; packages: 8 passed, 0 failed, 1 with no test files (pkg/version); tests: 1128 passed (346 top-level, 782 subtests), 0 failed, 0 skippedpkg/reporter/changelog_test.go(TestChangelogEntries,TestRepeatedChangelogHeadings,TestChangelogReleasesHaveOneHeadingPerKind,TestChangelogSaysWhereSARIFAndCSVCarryTheCryptoJSText): 4 passed in the run aboveNot included
None
Closes
Fixes #46
Fixes #47
Fixes #48
How to merge
Rebase and merge, so that each change stays its own commit on
main.