Skip to content

Batch: 3 changes, one commit each - #45

Merged
thebenignhacker merged 3 commits into
mainfrom
integrate/2026-10-21-r2
Oct 21, 2026
Merged

thebenignhacker merged 3 commits into
mainfrom
integrate/2026-10-21-r2

Conversation

@thebenignhacker

Copy link
Copy Markdown
Member

This pull request lands 3 commits in internal/cli, pkg/analyzer, pkg/reporter, pkg/scanner, pkg/types, docs, README.md, CHANGELOG.md and .goreleaser.yaml.

Included

Verified on this exact tree

  • go build -v ./...: exit 0
  • go vet ./...: exit 0, no output
  • go test -race -p 4 -count=1 -json ./...: exit 0; packages: 8 passed, 0 failed, 1 with no test files (pkg/version); top-level tests: 342 passed, 0 failed, 0 skipped; subtests: 782 passed, 0 failed, 0 skipped
  • goreleaser check: "1 configuration file(s) validated", exit 0
  • golangci-lint run --max-same-issues=0 --max-issues-per-linter=0 (golangci-lint 2.12.2, no repository config): exit 1, 88 issues (errcheck 48, staticcheck 40); on origin/main: exit 1, 85 issues (errcheck 45, staticcheck 40); the 3 more are errcheck reports on fmt.Fprintf in internal/cli/scan.go
  • the same command with a config that enables only the exclusion presets comments, common-false-positives, legacy and std-error-handling: exit 1, 40 issues (staticcheck 40) on this tree and the same 40 on origin/main
  • changelog: TestChangelogEntries and TestChangelogSaysWhereSARIFAndCSVCarryTheCryptoJSText in pkg/reporter passed in the test run above

Not included

Closes

Refs #7
Fixes #31
Refs #23

How to merge

Rebase and merge, so that each change stays its own commit on main.

…e skipped node_modules, cap the streamed list and plain help wording (#7)

Refs #7
Remaining, as each changes detection, an exit code or the README capture: hybrid classification of mlkem768x25519-sha256; a distinct exit code for tool errors; the score box border; repo-relative finding paths, URL scans included; the migration score framed as a path forward; the recommendation line; RC2 named by algorithm; assert messages and comments counted as withheld narrative; jsonwebtoken npm dependency inventory.
…yptoscan, and state the rule in the flag description (#31)

Fixes #31
…ependency fix, and use current GoReleaser keys (#23)

Refs #23
Still open in #23: certificate context for CERT-EXPIRY-001 and CERT-SUBJECT-001 and one finding for an RSA use and its key size (both detection changes), and a pinned golangci-lint version (needs a .github/ change).
@thebenignhacker
thebenignhacker merged commit 247a2e3 into main Oct 21, 2026
4 checks passed
@thebenignhacker
thebenignhacker deleted the integrate/2026-10-21-r2 branch October 21, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-update-capture writes a README block the test rejects unless the directory is named cryptoscan

1 participant