Repository navigation
Batch: 3 changes, one commit each - #45
Merged
Merged
Conversation
…e skipped node_modules, cap the streamed list and plain help wording (#7) Refs #7 Remaining, as each changes detection, an exit code or the README capture: hybrid classification of mlkem768x25519-sha256; a distinct exit code for tool errors; the score box border; repo-relative finding paths, URL scans included; the migration score framed as a path forward; the recommendation line; RC2 named by algorithm; assert messages and comments counted as withheld narrative; jsonwebtoken npm dependency inventory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 3 commits in
internal/cli,pkg/analyzer,pkg/reporter,pkg/scanner,pkg/types,docs,README.md,CHANGELOG.mdand.goreleaser.yaml.Included
Verified on this exact tree
go build -v ./...: exit 0go vet ./...: exit 0, no outputgo test -race -p 4 -count=1 -json ./...: exit 0; packages: 8 passed, 0 failed, 1 with no test files (pkg/version); top-level tests: 342 passed, 0 failed, 0 skipped; subtests: 782 passed, 0 failed, 0 skippedgoreleaser check: "1 configuration file(s) validated", exit 0golangci-lint run --max-same-issues=0 --max-issues-per-linter=0(golangci-lint 2.12.2, no repository config): exit 1, 88 issues (errcheck 48, staticcheck 40); onorigin/main: exit 1, 85 issues (errcheck 45, staticcheck 40); the 3 more are errcheck reports onfmt.Fprintfininternal/cli/scan.gocomments,common-false-positives,legacyandstd-error-handling: exit 1, 40 issues (staticcheck 40) on this tree and the same 40 onorigin/mainTestChangelogEntriesandTestChangelogSaysWhereSARIFAndCSVCarryTheCryptoJSTextinpkg/reporterpassed in the test run aboveNot included
.cryptoscan.yamlin the scanned tree can suppress every finding, and no output says so #9): changes the exit code ofscan --fail-onandgate(exitCodeininternal/cli/scan.go); not part of this batchexamples,fixtures,testdata,docsand similar directories is never reported, with no notice and no flag #10):git merge-tree --write-tree --name-only --merge-base 881bc8f HEAD 5611fdfon this branch exits 1 with conflicts inCHANGELOG.md,README.md,docs/commands.md,internal/cli/scan.go,pkg/reporter/text.goandpkg/scanner/scanner.goCloses
Refs #7
Fixes #31
Refs #23
How to merge
Rebase and merge, so that each change stays its own commit on
main.