Repository navigation
Read dependency manifests that start with a byte order mark, and list a package.json that cannot be decoded as not analyzed (#35) - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 1 commit in
pkg/analyzer,pkg/reporter,pkg/scanner,docs/ci.mdandCHANGELOG.md.Included
Verified on this exact tree
go build ./...: exit 0go build -o cryptoscan ./cmd/cryptoscan: exit 0go vet ./...: exit 0gofmt -lon every tracked Go file: no outputgo test -race -p 4 -count=1 -v ./...: 8 packages ok, 1 package with no test files, 297 tests passed (1006 including subtests), 0 failed, 0 skipped, counted from the--- PASS:,--- FAIL:and--- SKIP:linesgolangci-lint run ./...: exit 1, 21 issues (errcheck 15, staticcheck 6), PRE-EXISTING: with--max-same-issues 0 --max-issues-per-linter 0this tree and a detached worktree oforigin/maineach print 85 issues (errcheck 45, staticcheck 40), the same list when compared by path and messagecryptoscan scan crypto-samples --format jsonwith the built binary and with a build oforigin/main: 110 findings from each, the same list when compared by file, line, id and severityNot included
None
Closes
How to merge
Rebase and merge, so that each change stays its own commit on
main.