Repository navigation
Remove the "go report: A" badge from the README header, a shields.io static badge whose grade was written into its URL (#51) - #55
Merged
Conversation
…static badge whose grade was written into its URL (#51) README.md line 8 drew its "go report: A" badge from https://img.shields.io/badge/go%20report-A-brightgreen. That is a shields.io static badge, which draws the value written into its URL: on 2026-10-17 the same URL with F in place of A drew "go report: F". The badge linked to a goreportcard.com report, and the goreportcard.com badge for the module drew "go report: retired" that day. The badge is removed. The CI, License and Go Version badges are unchanged. TestDocsReadmeBadgesTakeTheirValuesFromASource reads the README badges and fails on a shields.io static badge unless it links to a file in the repository that holds its value, as the License badge links to LICENSE. On the README before this change it fails at README.md:8, and it passes after. TestStaticBadgeMessage checks which badge URLs are static and the value read from each static one, against what shields.io drew for them on 2026-10-17. Fixes #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 1 commit in
README.md,CHANGELOG.mdandcmd/cryptodeps.Included
Verified on this exact tree
go build ./...: exit 0go vet ./...: exit 0gofmt -l cmd internal pkg: exit 0, no files listedgolangci-lint run ./...(golangci-lint 2.12.2): exit 3,can't load config: unsupported version of the configuration: ""go test -race -p 4 -count=1 -json ./...: exit 0; packages: 13 ok, 0 failed, 3 with no test files; tests including subtests: 1606 passed, 0 failed, 1 skipped (TestIntegration_FetchPyPIPackage:pip not available, skipping test); top-level tests: 522 passedNot included
None
Closes
Fixes #51
How to merge
Rebase and merge, so that each change stays its own commit on
main.