Repository navigation
feat: no defaults, exports traits only - #13
Merged
Merged
Conversation
Signed-off-by: Mike Lodder <mikelodder@tectonic.xyz>
dhuseby
requested changes
Oct 14, 2026
dhuseby
left a comment
dhuseby
left a comment
Member
There was a problem hiding this comment.
Just one little nit in the deserialization code. I'm surprised clippy didn't catch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the various hash functions to be selected arbitrarily. If none are selected, only the traits are exported. This is useful when the cryptography will be provided externally.
I also did some minor performance improvements and fixed
cargo docwhich wasn't building before.