Repository navigation
test(integration): fix docker-in-docker tests on ubuntu-26.04 runners - #149
Conversation
…ils to start Both docker-in-docker tests waited for the inner dockerd and, on timeout, reported only that its socket was absent. The feature's docker-init.sh logs dockerd and containerd to /tmp; include their tail, the kernel and the selected iptables alternative in the failure. The first test's inline copy of the wait loop now uses waitInnerDockerd. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ghost
left a comment
There was a problem hiding this comment.
Code Review — 9547928 · CLEAN
I found no concrete defect in this one-commit, one-file change at 9547928f308de63df56e600ef2bb2fd7ff65808c; the bounded, best-effort diagnostics only run after the existing dockerd readiness timeout and preserve the test's failure outcome.
What I reviewed
Coverage: Reviewed the changed integration-test helper and its callers, including Engine.Exec's context and output behavior, against the core review dimensions and repository guidance at base 8800af2aab1f9180f8edf5b90000158717b756c0. Checked correctness/failure paths and test coverage under R8; no new test invariant or production behavior is introduced. .dap/code-review.yml and AGENTS.md/CLAUDE.md are absent at the governing SHA; applied .dap/review/engineering.md and CONTRIBUTING.md instead. Other conditional dimensions do not apply to this diagnostic-only test change. Did not run tests or the system under review.
CLEAN — this round found nothing. Reply in a finding's own thread to argue it. On the pull request I answer @dap-code-review-by-crunchloop review, pause and resume.
ghost
left a comment
There was a problem hiding this comment.
No open findings on 9547928.
The DAP Code Review check run remains the verdict of record. This approval is dismissed if a finding reopens or a later head is not clean.
ubuntu-latest moved to ubuntu-26.04 (kernel 7.0) and both docker-in-docker tests began failing on every runner, main included. The inner dockerd log, now reported, shows why: docker-in-docker:2 (2.17.0) switches a Debian image to iptables-legacy unconditionally at install time, and on a kernel without legacy iptables dockerd exits with "failed to create NAT chain DOCKER: iptables v1.8.9 (legacy)". v4 checks at install time and re-selects at container start, choosing nft there. Move dindFeatureRef to :4. v4 declares a second volume (/var/lib/containerd); the first test now cleans up with cleanupComposeWorkspace, which removes every project volume, instead of only the /var/lib/docker one. Pinning the runner to ubuntu-24.04 was not taken: it hides the incompatibility until that image retires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dismissed by DAP code review: fe7d636 has not been reviewed clean (the pull request was pushed to).
ghost
left a comment
There was a problem hiding this comment.
Code Review — fe7d636 · CLEAN
The change updates the Docker-in-Docker integration tests to use feature v4 and shared diagnostics/cleanup helpers; I found no concrete defects introduced by these changes.
What I reviewed
Coverage: Reviewed fe7d636dd1e1ef8b136bf3eb66f2cf508419f17e (2 commits, 1 changed file), including integration-test correctness and coverage, cleanup/resource lifecycle, and failure diagnostics. Checked the shared cleanup helper and its callers, the compose volume creation and labels, and the CI integration-test configuration. Read .dap/review/engineering.md, CONTRIBUTING.md, and README.md at the governing base SHA 8800af2aab1f9180f8edf5b90000158717b756c0; .dap/code-review.yml is absent, so the repository’s engineering standard and core review dimensions guided this review. No findings or suspicions remain. Conditional dimensions for transactions, redelivery, schemas or published interfaces do not apply.
CLEAN — this round found nothing. Reply in a finding's own thread to argue it. On the pull request I answer @dap-code-review-by-crunchloop review, pause and resume.
ghost
left a comment
There was a problem hiding this comment.
No open findings on fe7d636.
The DAP Code Review check run remains the verdict of record. This approval is dismissed if a finding reopens or a later head is not clean.
|
All six integration shards passed on ubuntu-26.04 (both Go versions), including |
TestComposeSource_DockerInDocker*started failing on every runner. That includes a rerun of main's last green commit (8800af2), so this isn't caused by any open PR.Cause
Between 2026-10-28 and 2026-11-04,
ubuntu-latestmoved from ubuntu-24.04 (Docker 28.0.4) to ubuntu-26.04 (kernel 7.0, Docker 29.4.2).The tests used
ghcr.io/devcontainers/features/docker-in-docker:2, which resolves to 2.17.0. On a Debian image, v2'sinstall.shswitches toiptables-legacyunconditionally at install time. Kernel 7.0 no longer supports legacy iptables, so the inner dockerd exits. Its log (surfaced by the first commit) shows:v4 (4.1.3) checks for legacy support at install time and re-selects at container start (
iptablesSwitchAtRuntime, default true). That makes it choose nft on these hosts.Changes
waitInnerDockerd.dindFeatureRefmoves to:4./var/lib/dockervolume,privilegedand thedocker-init.shentrypoint that these tests cover./var/lib/containerdvolume. The first test now cleans up withcleanupComposeWorkspace, which removes every project volume.Not taken: pinning
runs-on: ubuntu-24.04. It would only hide the incompatibility until that runner image is retired.🤖 Generated with Claude Code