Repository navigation
deps: bump the moby group across 1 directory with 2 updates - #131
Conversation
ghost
left a comment
There was a problem hiding this comment.
Code Review — da4f040 · CLEAN
Clean review: no findings. This is a Dependabot group bump of moby/moby/api v1.55.0→v1.56.0 and moby/moby/client v0.5.1→v0.6.0 with no code change, and I found no incompatibility with any call site.
What I reviewed
What I verified, by reading the module sources of both versions (downloaded into the module cache; nothing built or executed):
- api diff —
diff -rqof api@v1.55.0 vs api@v1.56.0 shows only docs, swagger, Dockerfile, go.mod/go.sum, and test files changed. No Go type in any package this repo imports (container,mount,network,build) changed. - client diff — no exported signature or type was removed or changed. The only exported changes are the
MaxAPIVersionconst (1.55→1.56, the point of the bump) and a new additiveWithMessagePrinteroption. Everything else is unexported internals: thesendRequest/post/buildRequestfamily reordered body/headers arguments (unreachable from outside the package), avalueOrZerohelper preservingContainerUpdatesemantics, and capability normalization moved from an in-place mutation of the caller'sHostConfigto a non-mutating shallow copy innormalizeHostConfig— semantically identical normalization, and strictly better for callers. - Version pairing — client v0.6.0's go.mod requires api v1.56.0, matching the bump; the dropped intra-monorepo
replacedirective was never applicable downstream.go mod downloadresolved both modules cleanly against the PR's go.mod/go.sum. - Call sites — I enumerated every
client.*symbol this repo uses (client.New,FromEnv,WithHost,Ping, the container/exec/image/network/volume option types and methods acrossruntime/docker/) and each still exists with the same shape. The version-negotiation comment inruntime/docker/client.go:35remains accurate.
Coverage account: I worked interface-contract and correctness (the only dimensions a dependency-only bump can fire under in this repo) and verified the compat surface as above; the conditional dimensions (state-integrity, redelivery, version-compatibility on this repo's own persisted shapes, etc.) have no condition met by a two-line go.mod diff. I reviewed the diff at head da4f040 (1 commit, 2 files). The repository publishes no .dap/code-review.yml; its standard lives in .dap/review/engineering.md, which I read at the base SHA — its out-of-bounds rule for dependency bumps ("beyond an actual incompatibility you can point at in the diff") is satisfied since none exists. I did not run the build or test suite; a go build ./... run by CI would confirm compilation, but source reading found nothing that could break it.
CLEAN — this round found nothing. Reply in a finding's own thread to argue it. On the pull request I answer @dap-code-review-by-crunchloop review, pause and resume.
ghost
left a comment
There was a problem hiding this comment.
No open findings on da4f040.
The DAP Code Review check run remains the verdict of record. This approval is dismissed if a finding reopens or a later head is not clean.
da4f040 to
b52f5a6
Compare
Dismissed by DAP code review: b52f5a6 has not been reviewed clean (the pull request was pushed to).
Bumps the moby group with 2 updates in the / directory: [github.com/moby/moby/api](https://github.com/moby/moby) and [github.com/moby/moby/client](https://github.com/moby/moby). Updates `github.com/moby/moby/api` from 1.55.0 to 1.56.1 - [Release notes](https://github.com/moby/moby/releases) - [Commits](moby/moby@api/v1.55.0...api/v1.56.1) Updates `github.com/moby/moby/client` from 0.5.1 to 0.6.2 - [Release notes](https://github.com/moby/moby/releases) - [Changelog](https://github.com/moby/moby/blob/v0.6.2/CHANGELOG.md) - [Commits](moby/moby@v0.5.1...v0.6.2) --- updated-dependencies: - dependency-name: github.com/moby/moby/api dependency-version: 1.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: moby - dependency-name: github.com/moby/moby/client dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: moby ... Signed-off-by: dependabot[bot] <support@github.com>
b52f5a6 to
5ea1ddd
Compare
ghost
left a comment
There was a problem hiding this comment.
Code Review — 5ea1ddd · CLEAN
No concrete incompatibility was found in this dependency-only Moby bump.
What I reviewed
Coverage: Reviewed commit 5ea1ddd148487ab4491cb321fcd5f4df4a1a2808 (one commit; two files, go.mod and go.sum). Checked dependency consumers in runtime/docker, the pinned Moby client/API compatibility and API negotiation behavior, and the upstream client release changes. Correctness and interface-contract mechanisms are covered to the extent applicable to the dependency changes; no changed runtime code or schema behavior was found. The repository standard at base 8800af2aab1f9180f8edf5b90000158717b756c0 is .dap/review/engineering.md; .dap/code-review.yml does not exist. The repo-specific standard explicitly excludes dependency version bumps absent a concrete incompatibility, and none was established. No applicable conditional dimensions were triggered.
CLEAN — this round found nothing. Reply in a finding's own thread to argue it. On the pull request I answer @dap-code-review-by-crunchloop review, pause and resume.
ghost
left a comment
There was a problem hiding this comment.
No open findings on 5ea1ddd.
The DAP Code Review check run remains the verdict of record. This approval is dismissed if a finding reopens or a later head is not clean.
Bumps the moby group with 2 updates in the / directory: github.com/moby/moby/api and github.com/moby/moby/client.
Updates
github.com/moby/moby/apifrom 1.55.0 to 1.56.1Release notes
Sourced from github.com/moby/moby/api's releases.
Commits
14ebc60Merge pull request #53830 from tonistiigi/update-buildkit-v0.34.0-rc18eded0eMerge pull request #53671 from thaJeztah/add_WithHTTPRequestHookc4e39afMerge pull request #53596 from vvoland/c8d-refactor-imgloadb8a569eclient: add WithHTTPRequestHook option0fed273Merge pull request #53803 from thaJeztah/etchosts_cleanups80c72a3Merge pull request #53831 from corhere/fix-dnsproxy-servfail-test1cfa161daemon/containerd: Split image loading into import and unpack stepse7272aaMerge pull request #53606 from flostellbrink/fix/swagger-yaml-indentation357096elibnetwork/etchosts: keep file open when updating hosts012b2eflibnetwork/etchosts: propagate file close errorsUpdates
github.com/moby/moby/clientfrom 0.5.1 to 0.6.2Release notes
Sourced from github.com/moby/moby/client's releases.
Changelog
Sourced from github.com/moby/moby/client's changelog.
... (truncated)
Commits
ca5913fBump version to 0.6.2b2707dcMerge pull request #1898 from dotcloud/smallfix_registryb826351Merge pull request #1897 from dotcloud/update_doc2183644Information about data persistencee836b00Prevent panic upon error pulling registry986906cMerge pull request #1892 from dotcloud/fix-maintainers-files8d48119Merge pull request #1894 from dotcloud/1891-remove_useless_warningscdce873Merge pull request #1896 from dotcloud/1885-missing-hostfile5a01f74Only mount hostname files if config exists45b5073Merge pull request #1849 from dotcloud/better_handle_hostConfig