Skip to content

feat(download): add --no- forms of the export option flags - #1157

Merged
andrii-bodnar merged 1 commit into
mainfrom
export-options-update
Oct 27, 2026
Merged

andrii-bodnar merged 1 commit into
mainfrom
export-options-update

Conversation

@bhdnb

@bhdnb bhdnb commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

--no-skip-untranslated-strings, --no-skip-untranslated-files and --no-export-only-approved switch the option off for one run, overriding crowdin.yml and the project export settings. The positive flags now override a false in crowdin.yml as well. Precedence: CLI flag, then crowdin.yml, then project settings.

On Crowdin Enterprise, an explicit false (CLI or crowdin.yml) now sends exportWithMinApprovalsCount: 0, which overrides the project's min-approvals setting. Before, export_only_approved: false sent nothing, so the project setting still applied.

Skipping untranslated strings and skipping untranslated files together is now rejected once CLI flags and crowdin.yml are combined, not only when both flags are passed. With --no-skip-untranslated-files, a download that finds no files now fails instead of showing the "Skip untranslated files" warning.

@bhdnb
bhdnb requested a review from andrii-bodnar October 27, 2026 13:29
@bhdnb bhdnb self-assigned this Oct 27, 2026
@bhdnb bhdnb added the new option New option for an existing command label Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (fae6d6e) to head (3ec60d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
+ Coverage   93.70%   93.71%   +0.01%     
==========================================
  Files         159      159              
  Lines       13090    13104      +14     
==========================================
+ Hits        12265    12279      +14     
  Misses        825      825              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrii-bodnar
andrii-bodnar merged commit cb2d12d into main Oct 27, 2026
13 checks passed
@andrii-bodnar
andrii-bodnar deleted the export-options-update branch October 27, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new option New option for an existing command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants