Skip to content

Test py git bot feedback - #63

Open
2bndy5 wants to merge 3 commits into
masterfrom
test-py-git-bot-feedback
Open

2bndy5 wants to merge 3 commits into
masterfrom
test-py-git-bot-feedback

Conversation

@2bndy5

@2bndy5 2bndy5 commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

testing cpp-linter/cpp-linter#226 in PR context

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v17.0.6) reports: 2 file(s) not formatted
  • src/demo.cpp
  • src/demo.hpp
clang-tidy (v17.0.6) reports: 8 concern(s)
  • src/demo.cpp:2:1: warning: [misc-include-cleaner]

    included header demo.hpp is not used directly

        2 | #include "demo.hpp"
          | ^~~~~~~~~~~~~~~~~~~
        3 | #include <stdio.h>
  • src/demo.cpp:3:10: warning: [modernize-deprecated-headers]

    inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead

        3 | #include <stdio.h>
          |          ^~~~~~~~~
          |          <cstdio>
  • src/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

        8 | int main(){
          | ~~~ ^     
          | auto       -> int
  • src/demo.cpp:10:13: warning: [readability-braces-around-statements]

    statement should be inside braces

       10 |     for (;;) break;
          |             ^      
          |              {
  • src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

    do not call c-style vararg functions

       13 |     printf("Hello world!\n");
          |     ^
  • src/demo.hpp:6:11: warning: [cppcoreguidelines-use-default-member-init]

    use default member initializer for 'useless'

        6 |     char* useless;
          |           ^      
          |                  {"\0"}
        7 |     int numb;
        8 |     Dummy() :numb(0), useless("\0"){}
          |                       ~~~~~~~~~~~~~
  • src/demo.hpp:7:9: warning: [cppcoreguidelines-use-default-member-init]

    use default member initializer for 'numb'

        7 |     int numb;
          |         ^   
          |             {0}
        8 |     Dummy() :numb(0), useless("\0"){}
          |              ~~~~~~~
  • src/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]

    use a trailing return type for this function

       11 |     void *not_useful(char *str){useless = str;}
          |     ~~~~~~^                    
          |     auto                        -> void *

✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v17.0.6

Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..8caf462 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2,2 +2 @@
-#include "demo.hpp"
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +4,2 @@
+auto main() -> int
+{
@@ -6,6 +7,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +16,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..1cf7f24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
-    public:
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Used clang-format v17.0.6

Only 5 out of 7 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..86d9f03 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;)
+        break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..dad4fd6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -8,4 +6,8 @@ class Dummy {
-    Dummy() :numb(0), useless("\0"){}
-
-    public:
-    void *not_useful(char *str){useless = str;}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
+
+public:
+    void* not_useful(char* str) { useless = str; }
@@ -14,19 +16 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -35 +18,0 @@ struct LongDiff
-

Have any feedback or feature suggestions? Share it here.

Comment thread src/demo.cpp

// using size_t from cstddef
size_t dummyFunc(size_t i) { return i; }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format suggestion

Suggested change
int main()
{

Comment thread src/demo.cpp
Comment on lines +6 to +11


int main(){

for (;;) break;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format suggestion

Suggested change
int main(){
for (;;) break;
for (;;)
break;

clang-tidy diagnostics

Suggested change
int main(){
for (;;) break;
for (;;) {
break;
}

Comment thread src/demo.cpp
Comment on lines +15 to +18



return 0;}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format suggestion

Suggested change
return 0;}
return 0;
}

Comment thread src/demo.hpp
Comment on lines +8 to +11
Dummy() :numb(0), useless("\0"){}

public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format suggestion

Suggested change
Dummy() :numb(0), useless("\0"){}
public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}
Dummy()
: numb(0)
, useless("\0")
{
}
public:
void* not_useful(char* str) { useless = str; }

Comment thread src/demo.hpp
{

long diff;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format suggestion

Please remove the line(s)

  • 35

Comment thread src/demo.cpp
#include <cstdio>
#include <cstddef>
#include <stdio.h>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy suggestion

Suggested change
auto main() -> int
{

Comment thread src/demo.cpp



return 0;}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy suggestion

Suggested change
return 0;}
return 0;
}

Comment thread src/demo.cpp
for (;;) break;


printf("Hello world!\n");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostic

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

   13 |     printf("Hello world!\n");
      |     ^

Comment thread src/demo.hpp
Comment on lines 6 to +8
char* useless;
int numb;
Dummy() :numb(0), useless("\0"){}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Suggested change
char* useless;
int numb;
Dummy() :numb(0), useless("\0"){}
char* useless { "\0" };
int numb { 0 };
Dummy() { }

Comment thread src/demo.hpp
Comment on lines 10 to +11
public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy diagnostics

Suggested change
public:
void *not_usefull(char *str){
useless = str;
return 0;
}
void *not_useful(char *str){useless = str;}
public:
auto not_useful(char* str) -> void* { useless = str; }

@2bndy5
2bndy5 force-pushed the test-py-git-bot-feedback branch from 1711f3a to 6b1fa36 Compare October 6, 2026 15:59
github-actions[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot dismissed their stale review October 7, 2026 07:07

outdated review

github-actions[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot dismissed their stale review October 8, 2026 06:51

outdated review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v17.0.6

Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..8caf462 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -2,2 +2 @@
-#include "demo.hpp"
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +4,2 @@
+auto main() -> int
+{
@@ -6,6 +7,3 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;) {
+        break;
+    }
@@ -18 +16,2 @@ int main(){
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..1cf7f24 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -6,3 +6,3 @@ class Dummy {
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
@@ -10,2 +10,2 @@ class Dummy {
-    public:
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }

Used clang-format v17.0.6

Only 5 out of 7 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch
diff --git a/src/demo.cpp b/src/demo.cpp
index 1bf553e..86d9f03 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
-    for (;;) break;
-
+    for (;;)
+        break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index f93d012..dad4fd6 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +2,0 @@
-
-
@@ -8,4 +6,8 @@ class Dummy {
-    Dummy() :numb(0), useless("\0"){}
-
-    public:
-    void *not_useful(char *str){useless = str;}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
+
+public:
+    void* not_useful(char* str) { useless = str; }
@@ -14,19 +16 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {
@@ -35 +18,0 @@ struct LongDiff
-

11 review comment(s) from a previous review were reused (not posted again).


✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant