Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A precompiled
google-re2expression withOptions.case_sensitive = FalsematchesSECRETwith the simple backend, but selecting an accelerated backend recompiles only itspatterntext and loses that option. The defaultbestselection can therefore change inclusion/exclusion results merely when an optional backend is installed.Return unsupported from the existing foreign-expression guard, as its comment already intends. Automatic selection then retains the original compiled object with the simple backend; explicit native selection returns the existing guidance to use
backend='simple'. Native Python patterns retain their existing path, and inactive foreign patterns do not force fallback.Adds proxy and real-RE2 regressions, inactive-pattern/index controls, and synchronized documentation. Ten failing baseline subcases become passing; the full Python 3.12 suite runs 298 tests successfully with one existing skip and both native backends installed. Another 84 option/order/exclusion cases pass in independent review. Mypy and Pyright findings are byte-identical on baseline and patch; other Python/OS combinations were not run.
This covers foreign compiled objects, distinct from the stdlib flag preservation in #151.
AI-assisted investigation, implementation, tests and writing; independently reviewed. No production incident is claimed.