Repository navigation
[fix][evaluation]: retain sandbox scheduling workspace for shared targets - #702
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage 78.97% 78.97%
=======================================
Files 707 707
Lines 88174 88191 +17
=======================================
+ Hits 69633 69650 +17
Misses 14557 14557
Partials 3984 3984
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ming845378603
approved these changes
Oct 27, 2026
Celoria
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
When an experiment uses a sandbox target shared from another workspace, its execution record remains in the target workspace while the sandbox belongs to the experiment workspace. Cleanup and polling must address the sandbox's actual workspace.
Persist and preserve the operator-provided
sandbox_workspace_idthrough callbacks and termination, use it for sandbox cleanup and status polling, and reject callback attempts to inject or replace this internal metadata. Pass the source workspace separately for adapter configuration and account cleanup. Records without metadata retain their original cleanup workspace; record-creation failures use the experiment workspace directly.Validation: targeted service tests passed for cross-workspace records, callbacks, termination, zombie cleanup, polling, legacy records, Debug, and record-creation failures.
git diff --checkand CI-version golangci-lint v2.2.1 for the changed packages passed (0 new issues).