Skip to content

[fix][evaluation]: retain sandbox scheduling workspace for shared targets - #702

Merged
ming845378603 merged 1 commit into
mainfrom
codex/fix-sandbox-experiment-space
Oct 27, 2026
Merged

ming845378603 merged 1 commit into
mainfrom
codex/fix-sandbox-experiment-space

Conversation

@lizwang11

Copy link
Copy Markdown
Collaborator

What type of PR is this?

fix

Check the PR title

  • The title uses the required type/scope format and describes the behavior.
  • The description is user-oriented and clear.
  • No user-facing documentation change is required.
  • This PR is written in English.

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
When an experiment uses a sandbox target shared from another workspace, its execution record remains in the target workspace while the sandbox belongs to the experiment workspace. Cleanup and polling must address the sandbox's actual workspace.

Persist and preserve the operator-provided sandbox_workspace_id through callbacks and termination, use it for sandbox cleanup and status polling, and reject callback attempts to inject or replace this internal metadata. Pass the source workspace separately for adapter configuration and account cleanup. Records without metadata retain their original cleanup workspace; record-creation failures use the experiment workspace directly.

Validation: targeted service tests passed for cross-workspace records, callbacks, termination, zombie cleanup, polling, legacy records, Debug, and record-creation failures. git diff --check and CI-version golangci-lint v2.2.1 for the changed packages passed (0 new issues).

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...d/modules/evaluation/domain/service/target_impl.go 96.96% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files         707      707           
  Lines       88174    88191   +17     
=======================================
+ Hits        69633    69650   +17     
  Misses      14557    14557           
  Partials     3984     3984           
Flag Coverage Δ
unittests 78.97% <96.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...d/modules/evaluation/domain/service/target_impl.go 85.07% <96.96%> (+0.25%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 434767e...744288d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ming845378603
ming845378603 merged commit 82d4a65 into main Oct 27, 2026
17 checks passed
@ming845378603
ming845378603 deleted the codex/fix-sandbox-experiment-space branch October 27, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants