Skip to content

fix(app): pictures show in a markdown file's preview again, and cmd-click opens markdown from a terminal - #167

Merged
joeauyeung merged 3 commits into
mainfrom
markdown-preview-followup
Oct 19, 2026
Merged

joeauyeung merged 3 commits into
mainfrom
markdown-preview-followup

Conversation

@joeauyeung

@joeauyeung joeauyeung commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #157. Two commits landed on its branch after it merged, so they never reached main.

What you get

  • Pictures show in a Markdown file's Preview again. v0.3.27 and v0.3.28 shipped the Preview without them. 8ffaab7f ("show worktree pictures in agent replies") changed Markdown to turn every <img> into an inert cv-image-slot for chat replies (lib/chat-images.ts), so the Preview's loader never found an image. With localImages, the slots now turn back into pictures: a worktree path loads from the box as a blob: URL, and an https: URL loads as it is (README badges). Chat replies are unchanged and still never load a web picture.
  • ⌘-click a Markdown path in a terminal to open it in a File tab as a page, when it's a file of the worktree you're in. ⌘⇧-click sends it to your editor. Every other file goes to the editor as before.

The changelog has both under ## Unreleased. The ⌘-click line I had added to v0.3.27's notes is moved there.

Checks

  • typecheck:plugins, check:titles, check:type, check:grid, check:csp, check:themes, pnpm test (554 pass), pnpm build, npx tsc -p e2e, docs build: all pass
  • e2e/markdown.spec.ts, chat.spec.ts, home-terminal.spec.ts: 18 passed. markdown.spec.ts's picture test fails on main today and passes here.
  • No automated test for the terminal ⌘-click: the terminal draws on a canvas. It needs a manual check in the app.

🤖 Generated with Claude Code

joeauyeung and others added 3 commits October 19, 2026 10:22
A Markdown file of the worktree, cmd-clicked in a terminal, opens in a
File tab with its Preview instead of the external editor. Cmd-shift-click
still sends it to the editor, and every other file goes there as before.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…in's chat image slots

Main now turns every Markdown image into an inert slot for chat replies,
so the Preview's own loader never saw an img. In a file's Preview the
slots go back to pictures: worktree paths from the box, https from the
web. Replies keep their cards and still never load a web picture.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
berth Ready Ready Preview Oct 19, 2026 2:24pm UTC
berth-docs Ready Ready Preview Oct 19, 2026 2:24pm UTC

Request Review

@joeauyeung
joeauyeung merged commit b6c5bec into main Oct 19, 2026
8 checks passed
@linear-code

linear-code Bot commented Oct 19, 2026

Copy link
Copy Markdown

ENG-6444

This branch was successfully deployed

2 active deployments
Preview – berth-docs — 0a2eb461 Deployed Oct 19, 2026 by vercel[bot]
Preview – berth — 0a2eb461 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant