Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
Summary
toGeminiSchemaalready normalizesanyOf/oneOfnull unions into{ type, nullable: true }, but JSON Schema nullable type arrays (type: ["string", "null"]) reachedtypeof inputSchema.type === 'string'as an array and had theirtypedropped. Tools that declare nullable arguments via type arrays (such as OpenCode 2.x tools withtype: ["string", "null"]) then failed on Gemini models with HTTP 400.Changes
normalizeNullableTypeArrayinpackages/core/src/transform/gemini.tsaftermergeSchemaAllOfto normalize:["string", "null"],["null", "integer"], etc., case-insensitive and deduplicated) to{ type: "<type>", nullable: true }["string"]->type: "string",["null"]->type: "null")allOf-merged schemas["string", "number"]) and unknown type entries untouched so existing provider validation handles them without misclassifying schema errors.packages/core/src/transform/gemini.test.ts.Verification
bun test --isolate packages/core/src/transform/gemini.test.ts(166 pass, 0 fail)bun run --cwd packages/core typecheck(0 errors)bun x @biomejs/biome check packages/core/src/transform/gemini.ts packages/core/src/transform/gemini.test.tsnullarguments onantigravity-gemini-3.8-flashandantigravity-gemini-4-argon.