Repository navigation
fix(setup): grant the vault-approved enrollment principal (#471) - #472
Merged
Merged
Conversation
Read approvedName through common-auth's public enrollment-status API, validate it before building ck arguments, and retain the same principal in the empty-vault remedy. Keep default names only for records without an approved name. Add red-first coverage and a default-principal mutation control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #471 (item 4). Setup always granted
enrolled:<default name>, even when the vault operator approved this installation under another name, so that installation never got read access. Setup now reads the approved name from common-auth's public enrollment status and grants that principal, falling back to the default only when none is recorded; an invalid name refuses before runningck. The empty-vault remedy and docs/vault.md name the approved principal too. Red-first tests and a mutation row.