Skip to content

land: ci-sccache-fallback - #967

Queued
aft-alfonso[bot] wants to merge 3 commits into
mainfrom
land/ci-sccache-fallback
Queued

aft-alfonso[bot] wants to merge 3 commits into
mainfrom
land/ci-sccache-fallback

Conversation

@aft-alfonso

@aft-alfonso aft-alfonso Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Accepted agent delivery; branch-keyed search descriptor included.

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking request to test preservation of custom cache settings.

Findings

  1. P2 Custom settings lack coverage ▶

Summary

Adds retrying sccache startup and an uncached fallback across unit, end-to-end, release, and search-quality builds.

  • Rust build jobs can keep going when the compiler cache won't start.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Cache setup may fail] --> B[Run startup helper]
  B --> C{Explicit configuration?}
  C -->|No| D[Write 30-second startup timeout]
  C -->|Yes| E[Keep existing configuration]
  D --> F[Try startup up to three times]
  E --> F
  F -->|Success| G[Keep compiler cache enabled]
  F -->|All attempts fail| H[Clear RUSTC_WRAPPER and warn]
  H --> I[Build without compiler cache]
Loading

Reviews (1) · Last reviewed commit: "release notes and search-quality descrip..." · Reviewed by Greptile

ualtinok and others added 2 commits October 26, 2026 07:40
Start sccache explicitly with three bounded attempts in every cache-enabled job, including reusable suites and Windows release jobs. Use the documented file-only startup timeout and clear the job-wide Rust wrapper on failure. Keep the cache action's setup and post-stat failures non-fatal, and do not re-enable the measurement wrapper after fallback.

Add a workflow-free stubbed startup regression test and run it in CI guards. Before the helper fix, failed_startup_runs_uncached failed with startup step exited 2, expected 0. The final Linux dry suite passes all 3 cases; deleting the GITHUB_ENV wrapper reset reddens only failed_startup_runs_uncached, and restoring the helper returns all 3 cases to green with an empty git diff. No existing test contract was rewritten.

Validated all 10 workflows with actionlint 1.7.12 and both scripts with ShellCheck 0.11.0. Auxiliary Python workflow suites and root Biome lint could not start after repeated Linux capacity refusals over an hour, including one-CPU retries; Windows verification was unreachable. No release-note fragment for this CI-only change.

Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Comment thread scripts/test-ci-sccache-start.sh Outdated
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile has paused reviews on this repository — it used its 750 free open-source review credits for this billing period. Reviews resume automatically on November 19. To continue before then, an organization admin can keep reviews running past the free credits — those bill as normal usage.

@ualtinok
ualtinok added this pull request to the merge queue Oct 26, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant