Repository navigation
Name a still-running cancelled command on the next call to any tool - #1067
Merged
Merged
Conversation
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit a47835c54947f59e8d3cb72e1f39419724da1177)
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit b42c3e76b6289c3d9090d531f5d509b7b51c1b41)
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit cc6912a1280eb457c88fe4454ec9a75b0e9adc55)
Use the shared per-call native-plumbing classifier before taskId translation, so native polls leave notices pending while agent calls consume them once. Management and health replies remain outside tool-result finalization. The owner-cancellation test now expects the next read reply to carry the notice, replacing its shell-only expectation as required by the approved behavior change. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit 6aac658bcf7660f2c104ef71eee05fd9b90a40e1)
Share notice rendering with standalone tool_call replies, without adding trailers to native plumbing, previews, or internal consent asks. Keep the existing admitted-call boundary: argument refusals leave notices pending for the next dispatched read, as covered by a routing regression. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit 9fe3a58a4552dcfcc7ca230c3e9a021a4b64f6c1)
…lled-call notices Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an agent's turn stops while a foreground command is still running, the command keeps going as a background task. AFT used to name it only on the session's next shell-family call (
bash,bash_status, ...). It now names it once on the next agent-visible reply of any tool, for examplereadoraft_search. Ufuk approved this behaviour; ALF reported the gap.Notices stay pending, not consumed, through replies the agent never sees: plugin plumbing polls (
bash_statuswithtask_id), previews, held permission asks, and refused calls (argument and translation refusals keep their existing path).Tests (through real subc routing and the standalone
tool_callpath): the notice appears exactly once on the nextread; it survives a native status poll, an argument refusal, a held access ask and a preview; a later status check doesn't repeat it; the agent'staskIdspelling ofbash_statusstill receives it. The owner-cancellation test now expects the notice onread. 42 filtered tests pass on Linux; Windows target check with -D warnings passes.Summary by cubic
Names a still-running cancelled command on the next agent-visible reply of any tool instead of only the next shell-family call. When an agent's turn stops while a foreground command keeps running as a background task, the notice now appears once on replies like
readoraft_search.Tests
read, survives native status polls, argument refusals, held access asks, and previews, and is not repeated by later status checks.read.Written for commit 7f363de. Summary will update on new commits.