Repository navigation
Flake batch 5: task-bundle lock, storm config publish, macOS thread inventory - #1051
Merged
Merged
Conversation
…session lock occipital_task_observation_is_limited_to_bound_session wrote two sessions' task bundles with task_paths + write_task, replaying each session in between. The first replay's detached GC can remove the second session's still-empty directory before its metadata is written (Linux, PR #996's merge group: write_task NotFound). Same fix as the consent scratch-task test: allocate through create_task_layout and write with write_task_at. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
…ers too The frame-pointer walk yields return addresses, so it names the running function's caller outward and never the running function. A spawned thread sampled while executing its own closure's code (or entering or leaving a callee before its frame record exists) therefore had no saved frame naming the closure, and the inventory reported only 'thread_start > _pthread_start'. This made thread_inventory_lists_a_new_unnamed_thread_with_its_start_routine fail intermittently on macOS CI, and would leave a real retained thread anonymous in a retention failure. The start routine search now falls back to the program counter's function and then, on arm64, the function the link register returns into. A hand-built-stack test covers both cases deterministically. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only fix for a merge-queue failure.
subc::tool_provider::route_tests::occipital_task_observation_is_limited_to_bound_sessionwrote two sessions' task bundles with task_paths + write_task, replaying each session in between. The first replay's detached GC could remove the second session's still-empty directory before its metadata was written (Linux, PR land: route-project-from-stamp #996's merge group:write_taskNotFound). It now allocates throughcreate_task_layoutand writes withwrite_task_at, the same fix the consent scratch-task test got in Merge-queue flake batch 2 #1043.Build server: -D warnings check; the test passed in 5 of 5 loops.
subc_storm_testpublished the shared storm root's project config with truncate-and-write on every rebind while a sibling route's bind read it; a torn read failed the bind withconfig_divergence(Linux release storm, PR land: bash-watch-each-line #911's group). It now writes a temp file and renames it into place, as #891: route binds read config off the frame loop and acknowledge on their own lane #984's fixture does.idle_root_retention_tests.rsnamed a thread's start routine only from saved frames, which never include the running function. A probe sampled while executing its own closure body reported justthread_start > _pthread_start(PR Accept worker codemode runs (worker-runs/v1) with the worker's own authority #1014's group, macOS libtest). It now also consults the program counter and, on arm64, the link register; saved frames still win. A hand-built stack test covers all three cases.