Repository navigation
Log lines carry their own session, never the last one the thread served (#1008) - #1011
Queued
aft-alfonso[bot] wants to merge 4 commits into
Queued
aft-alfonso[bot] wants to merge 4 commits into
aft-alfonso[bot] wants to merge 4 commits into
Conversation
…ion log fallback (#1008) The slow-bind warning ran on the frame loop outside any session scope and log_ctx fell back to LAST_SESSION, the last session that thread served, so operators were sent to an unrelated session. PendingBind now records the requesting session and the warning logs inside that session's scope. The LAST_SESSION fallback (8781458) existed only to avoid untagged watcher/gitignore lines on the assumption of one session per project. On threads that serve many sessions (request loop, frame loop, executor workers) it mislabels every unscoped line, and nothing depends on it: the CLI log readers already handle untagged lines. It is removed, so unscoped lines carry no session tag. Tests that asserted the fallback (session_prefix_format, set_session_direct, the falls-back/updates/none-does-not-clear tests and the integration slog_macros_prepend_session_tag case 2) are rewritten to the new contract on purpose: an unscoped line carries no session. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit 040014761aeb857a7181bbd3d09f3b3c726081ed)
#1008) The stuck-pending-watch scan, the scope-workdir comparison and three bash handoff/deadline warnings run on shared subc runtime or blocking-pool threads outside any session scope but each concerns one known session. Log each inside that session's scope so it carries the right tag instead of none. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit 446bfd98451dececbf84805f1268cc4f340843cb)
scope_workdir_mismatch_logs_once_and_preserves_project_root pins this line as untagged and its body already names the session. With the last-session fallback removed it can no longer carry a wrong session, so the wrap from the previous commit is reverted rather than changing that test. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit 0258b9505df5cdb6f2838376c7f7da0702f27892)
…note Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
ualtinok
added this pull request to the merge queue
Oct 26, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008. The slow-bind warning on the frame loop was tagged with whatever session that thread served last, because unscoped log lines fell back to LAST_SESSION. In the subc daemon one thread serves many sessions in turn, so that fallback sent operators to the wrong session.