Repository navigation
Stop empty grep/glob scope breakdowns at the request's deadline - #1005
Queued
aft-alfonso[bot] wants to merge 2 commits into
Queued
aft-alfonso[bot] wants to merge 2 commits into
aft-alfonso[bot] wants to merge 2 commits into
Conversation
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com> (cherry picked from commit 323d40b638ca150721d32bc910092fc174460902)
…ptor Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
ualtinok
added this pull request to the merge queue
Oct 26, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The breakdown AFT shows when a grep or glob scope holds no files (how many were ignored, filtered, examined) walked with its own 10 s budget, while the filesystem helper that runs it gives up after about 5 s. On very large checkouts the walk kept running on the probe thread after the reply had already said the breakdown could not be determined. In the 21:03Z perf sweep that thread took 18% of the live daemon's running samples.
Both probes now take the caller's deadline (with a return margin), so an oversized scope stops when the caller stops waiting. Counts are unchanged whenever the walk completes, and no reply text changes.
Test: empty_scope_probes_stop_at_an_expired_call_budget (fails without the fix: under a zero budget the walk ran to completion).