Repository navigation
Test: give the wait:true bash test 20 s instead of 5 s - #1003
Merged
Merged
Conversation
It checks that wait:true returns the command's terminal output, not how fast the command runs. On a loaded Windows runner the shell plus two printfs around a 1 s sleep took over 5 s and the timeout killed it (merge queue run 40395629042). 20 s stays under the test's 30 s frame read deadline. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only. subc_bridge_bash_wait_true_waits_for_terminal asserts that wait:true returns terminal output, not command speed; on a loaded Windows runner its 5 s command timeout killed the command before its last printf (merge queue run 40395629042, job 121836472353). 20 s keeps it under the test's 30 s frame read deadline.