Repository navigation
chore: one npm workspace for the playground, and a Renovate config that lands - #431
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
commit: |
robelest
marked this pull request as ready for review
October 29, 2026 15:53
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 19 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
1 task
robelest
force-pushed
the
chore/pnpm
branch
3 times, most recently
from
October 30, 2026 22:45
35cd41d to
5341caa
Compare
ianmacartney
approved these changes
Oct 30, 2026
ianmacartney
left a comment
ianmacartney
left a comment
Member
There was a problem hiding this comment.
this is ok, but keep in mind that as we unify some release tooling for components publishing from CI, those may all assume npm commands work. so adding this setup is some tech debt we're taking on to maintain the difference. Up to you if it's worth the gains over the current setup
…at lands The playground had its own lockfile, which Renovate resolved without the root (react@undefined), and the npm 10 constraint crashed on vitest's peers (edgesOut), so "Routine updates" has been stuck since April. - The playground is a workspace: one package-lock.json, still linked to the root through file:... - devEngines requires npm 11 or later, and allowScripts denies the esbuild and @swc/core install scripts that npm 12 blocks (both ship prebuilt binaries). - A check script (typecheck, lint, test) for the shared release workflow. - CI installs once and builds the playground with -w playground. - The playground release reads its version from package.json and commits the root lockfile, since npm version in a workspace doesn't commit or tag. - Renovate: no npm constraint, the routine group split by ecosystem, Monday mornings, no dashboard, 14 day release age as a rule, npmDedupe, no engines updates.
robelest
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stays on npm, per review, and fixes why Renovate's PRs never landed: the playground's separate lockfile resolved without the root (
react@undefined), and the npm 10 constraint crashed on vitest's peers (edgesOut, #242).package-lock.json, still linked to the root throughfile:...devEnginesrequires npm 11 or later.allowScriptsdenies the esbuild and @swc/core install scripts that npm 12 blocks (both ship prebuilt binaries).checkscript (typecheck, lint, test) for the shared release workflow.-w playground.package.jsonand commits the root lockfile, sincenpm versioninside a workspace doesn't commit or tag. Root releases are unchanged.npmDedupe, noenginesupdates. No automerge.