Skip to content

fix: No mangle on cimpl_free - #11

Merged
gpeacock merged 1 commit into
mainfrom
mathern/undo-mangle
Oct 2, 2026
Merged

gpeacock merged 1 commit into
mainfrom
mathern/undo-mangle

Conversation

@tmathern

@tmathern tmathern commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request

Remove the no_mangle on cimpl_free:

  • so that C symbols won't have it, enabling multiple libraries to use this crate at the same time without symbols collisions;
  • c_impl looks like a Rust API anyway, since the implementing Rust C FFI should use it.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@tmathern
tmathern requested a review from gpeacock October 2, 2026 15:53
@tmathern tmathern self-assigned this Oct 2, 2026
@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.15%. Comparing base (da629e6) to head (d0360e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files           2        2           
  Lines         815      815           
=======================================
  Hits          531      531           
  Misses        284      284           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpeacock gpeacock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to think about this one, but this is correct

@gpeacock
gpeacock merged commit 0443ed3 into main Oct 2, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants