Skip to content

fix(flink): reject application resources without metadata.name - #3483

Open
Minh Vu (fallintoplace) wants to merge 2 commits into
confluentinc:mainfrom
fallintoplace:fix/flink-application-metadata-name
Open

fix(flink): reject application resources without metadata.name#3483
Minh Vu (fallintoplace) wants to merge 2 commits into
confluentinc:mainfrom
fallintoplace:fix/flink-application-metadata-name

Conversation

@fallintoplace

@fallintoplace Minh Vu (fallintoplace) commented Aug 28, 2026

Copy link
Copy Markdown

Release Notes

Breaking Changes

  • NONE

New Features

  • NONE

Bug Fixes

  • confluent flink application create and update now return an error when metadata.name is missing, empty, or not a string instead of panicking.

Checklist

  • I have successfully built and used a custom CLI binary, without linter issues from this PR.
  • I have clearly specified in the What section below whether this PR applies to Confluent Cloud, Confluent Platform, or both.
  • I have verified this PR in Confluent Cloud pre-prod or production environment, if applicable.
  • I have verified this PR in Confluent Platform on-premises environment, if applicable.
  • I have attached manual CLI verification results or screenshots in the Test & Review section below.
  • I have added appropriate CLI integration or unit tests for any new or updated commands and functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Confluent Platform
    • Check this box if the feature is enabled for certain organizations only

What

Confluent Platform (CMF Flink).

  • Flink application resource files are decoded into a generic metadata map.
  • The create and update paths used a direct type assertion for metadata.name.
  • A valid YAML or JSON file without a usable name could panic the CLI.
  • This change validates the name before making the CMF request.

Blast Radius

  • Valid resource files behave the same.
  • Invalid metadata.name values now return a clear error.
  • Only Flink application create and update are affected.

References

  • NONE

Test & Review

  • go test ./pkg/flink ./internal/flink -count=1
  • go vet ./pkg/flink ./internal/flink
  • go build -o /dev/null ./cmd/confluent
  • Built binary verification: confluent --version
  • golangci-lint run --timeout 10m
  • make lint-cli
  • Unit tests cover valid, missing, empty, and non-string metadata.name values.
  • A parser-boundary regression test covers a YAML resource with missing metadata.name before create.

@fallintoplace
Minh Vu (fallintoplace) requested a review from a team as a code owner August 28, 2026 10:35
@confluent-cla-assistant

confluent-cla-assistant Bot commented Aug 28, 2026

Copy link
Copy Markdown

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ fallintoplace
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant