Skip to content

BL-2680 Fix Sentry timestamps on native BoxLang - #47

Open
elpete wants to merge 1 commit into
developmentfrom
fix/native-boxlang-timestamps
Open

elpete wants to merge 1 commit into
developmentfrom
fix/native-boxlang-timestamps

Conversation

@elpete

@elpete elpete commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Description

The Sentry module sends an invalid sent_at and event timestamp on native BoxLang without bx-compat-cfml. For 2026-09-14T00:49:38Z, the CFML mask yyyy-mm-dd'T'HH:nn:ss'Z' produces 2026-49-14T00:00:38Z, causing Sentry to reject the envelope before recording the error.

Use the shared named iso format in UTC. Epoch seconds and the capture/transport pipeline stay intact. The private timestamp helper accepts an optional reference time for deterministic regression coverage; normal capture still defaults to now().

This belongs in the Sentry module: native BoxLang follows Java mask semantics, and the original CFML mask works when bx-compat-cfml is installed. Changing core mask semantics would be inappropriate.

Issues

BL-2680 includes the standalone reproduction and environment comparison.

Type of change

  • Bug Fix

Validation

  • Reproduced the malformed timestamp on unmodified BoxLang main at e9809ec1cbe3a8e2893e1828b13fb52eb2b7ee22 and development at 208d839c3a6796b9f091021013a4b451042a70ea, both built from source and run with isolated module-free homes.
  • Deterministic timestamp regression failed with the original mask: expected 2026-09-14T00:49:38Z, received 2026-49-14T00:00:38Z.
  • All 3 timestamp TestBox specs pass on native BoxLang main and development, and on main with current bx-compat-cfml loaded.
  • All 3 specs also pass on Lucee 5.4.8.2 through CommandBox. The CLI emitted a non-fatal HTML-head cleanup warning and exited successfully after writing the test results.
  • Tests cover September/minute 49, January midnight, December/year-end, epoch/ISO agreement, default current time, and matching valid timestamps at the capture-to-transport boundary. HTTP transport is stubbed; no event is sent to Sentry.
  • Targeted cfformat and git diff --check pass.
  • The full Sentry integration suite, Adobe CF matrix, and live Sentry ingestion were not run.

Checklist

  • Code follows the project's cfformat rules.
  • Added regression coverage for the failure and the capture boundary.
  • Focused tests pass on the runtimes listed above.
  • Full existing suite and runtime matrix pass locally (not run).

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

lucee@5 ColdBox be Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

lucee@5 ColdBox ^7.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

lucee@5 ColdBox ^6.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

lucee@6 ColdBox be Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2018 ColdBox ^6.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2018 ColdBox ^7.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2023 ColdBox ^7.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

boxlang@1 ColdBox be Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2023 ColdBox ^6.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2021 ColdBox ^7.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2021 ColdBox ^6.0.0 Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2021 ColdBox be Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

adobe@2023 ColdBox be Test Results

29 tests   29 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit d77a396.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant