[colbymchenry]

What was wrong

Follow-up to #2671. A function value whose name the file imports from its own project still took matchFunctionRef's unique cross-file fallback whenever the import resolver bound the name to something that is not a function. It then linked to the project's one function of that name, wherever that was:

• A constant or class: outline's import { isCloudHosted } from '~/utils/isCloudHosted' (a boolean) linked to the server's isCloudHosted() policy helper, and its Star / Import / AuthenticationProvider model classes to the UI components of those names. signoz's import store from 'store' (the Redux store) linked to a test's local store factory, and bitwarden's eslint rule specs' errorMessage string constants to a web-app step's errorMessage().
• A namespace import: outline's import * as Slack from '../slack' (a module object) linked to the Slack plugin's settings component.
• An asset: topcoder's import TCO21 from './themes/TCO21.scss' and import QA from 'assets/images/img-QA.png' linked to those communities' route components, cord-field's .graphql document to a CreateStory component, and mastodon's visibility.svg?react icon to its VisibilityIcon component.

The fix

src/resolution/name-matcher.ts: the unique cross-file fallback also declines when a project import binds the name to something else (importBindsOther, JS family only, bare names):

• a namespace import (import * as X): the module object;
• an asset import, judged by the specifier's extension with any ?query/#hash stripped (stylesheets, images, GraphQL, JSON, fonts, media);
• an import the import resolver (context.resolveImport) binds to a node that is not a function or method.

Two bindings still lead to the namesake, because there it usually is what the value is:

• a wrapper declared in the same file as the namesake (function Disclosure…; export default styled(Disclosure));
• a lazy loader, i.e. a binding whose declaration holds a dynamic import( (signoz's Loadable(() => import('pages/Home'))), which loads the page it is named after.

An import the import resolver can't follow at all (a barrel it doesn't read, a .jsx file importing a .tsx module) still uses the fallback as before.

Tests

__tests__/function-ref-project-imports.test.ts:

• a constant, a model class and a namespace import, each beside a unique project function of that name → no edge;
• .scss, .png, .svg?react and .graphql imports → no edge;
• controls: a styled() wrapper beside its function, a lazy(() => import(...)) page, an export { default as … } from barrel and a plain function import keep their edges.

Red on main b8f81e2 (the first two tests fail with all seven edges), green with the fix. Mutation check: dropping the namespace, asset, same-file or lazy-loader rule each fails exactly the test that pins it.

Full suite on this branch at main b8f81e2 (Windows 11, kernel built from the tree, CODEGRAPH_KERNEL_EXPECT=1, --maxWorkers=4 --minWorkers=1): 7,485 passed, 80 skipped, 1 failed. The failure was awaited-receiver.test.ts's #1840 case hitting the 5 s default timeout under parallel load (the EBUSY is its teardown after the timeout). That file passes 11/11 alone, twice, and it exercises sync and await receivers, which function values never reach. Rebased afterwards onto main a50104c (#2672, React Router route tables: react.ts only); tsc --noEmit, both function-ref import tests, function-ref.test.ts and #2672's react-router-returned-tables.test.ts re-run green (45/45).

A/B on real repos

Same kit as #2671: 23 repos with stubbed node_modules. Both arms are this branch on main b8f81e2 with the same kernel, identical except dist/resolution/name-matcher.js. Every edge compared by source, target, kind, position and metadata; node counts are identical everywhere. For each removed edge, _main5's own resolver was asked (read-only) what the import binds.

repo	removed	added	the removed edges (value → where it had linked)
outline	58	0	ProseMirror node/mark/extension classes (Heading, Table, Video, Notice, ListItem, Link, History, Highlight, Embed; ×18) → React components of those names; model classes AuthenticationProvider ×7, Import ×4, Star ×2, Reaction → UI components; client error classes ×5 → server/errors.ts's factories; the Heading styled component ×6 → the email template's Heading; the isCloudHosted constant ×4 → server/policies/utils.ts:isCloudHosted; Empty ×3 → FilterOptions.tsx's local Empty; const Avatar = AvatarWithHoverCard ×3 → the base Avatar.tsx:Avatar; ListItem and the editor's Input → other components; the EditorUpdateError close code → a server factory; the Koa auth routes app → the auth middleware; import * as Slack → the Slack settings component
signoz	58	0	the Redux store from 'store' ×28 → a test's local store factory; each panel kind's sections ×20 → a test's sections helper; panel definition objects ({ definition as Histogram }, …) ×6 → the visualization chart components; a test helper replaceVariables → the generated querier's; mock accountsResponse → a stories mock; the Summary / Hosts tab-route objects → the pages those tabs mount (see below)
mastodon	14	0	story imports RadioButtonField, TextInputField, ToggleField, CharacterCounter (×2 each) → namesakes in redesign.tsx / another feature folder; the MediaGallery class ×2 → its async loader in async-components.js; the AutosuggestAccount class → another component; a createAction constant loadPending → timelines.js's loadPending(); visibility.svg?react ×2 → the VisibilityIcon component
excalidraw	9	0	import * as InteractiveCanvas from '../renderer/interactiveScene' ×8 and * as distance handed to spies → the InteractiveCanvas component and a distance() util
happa	8	0	the UI Button component ×7 → a stories file's Button; a reducer constant → scripts/utils.ts:error()
bitwarden	8	0	eslint rules' errorMessage strings ×6 → a web-app step's errorMessage(); spec-data folders / login constants → other specs' functions
topcoder	7	0	.scss ×2 and .png ×4 imports → community route components; an example class → a dashboard component
dho-web	3	0	Vue mixins: [truncate] (a mixin object) → utils/truncate.js:truncate()
windscribe	2	0	a test list's default export → the login form's login()
cord-field	1	0	a .graphql document → a CreateStory component
13 others	0	0	byte-identical

Triage: 167 of 168 removed edges were wrong. Each took a value that is a constant, class, module object or asset and linked it to an unrelated function that shares its name. The exception is SigNoz's pages/MetricsExplorer/constants.tsx Summary, a TabRoutes object { Component: SummaryPage, … }. The removed edge named the very component the tab mounts, but only by coincidence of names. The real path, SummaryPage → container/MetricsExplorer/Summary/index.ts (import Summary from './Summary'; export default Summary) → Summary.tsx, is a default-export forwarding gap in the import resolver, which #2451 (open) fills. Hosts is the same shape, but its flow survives through the constant's own HostsContainer edge.

Residual: after the fix, the only imports that bind a non-function and still lead to a namesake in another file are SigNoz's 49 pageComponents lazy loaders (Loadable(() => import('pages/…'))), kept by design. The same-file wrappers (outline ×4) are kept, and imports the import resolver can't follow (barrels, .jsx → .tsx) are untouched.

Cost: none measurable (outline 21 s / 22 s, signoz 30 s / 26 s, bitwarden 57 s / 51 s). The check runs only on the unique cross-file fallback for a name the file imports from the project.

Coordination

Builds on #2671, which gated the same fallback for package imports. No other open PR touches matchFunctionRef.

🤖 Generated with Claude Code